[AND-487] (xml): Replace VideoView with ExoPlayer + PlayerView. #5767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
…pose # Conflicts: # CHANGELOG.md
…hem follow the parent Box size (MediaGalleryVideoPage).
…ture/introduce-exoplayer-for-video-xml # Conflicts: # CHANGELOG.md
…ture/introduce-exoplayer-for-video-xml
…ture/introduce-exoplayer-for-video-xml
SDK Size Comparison 📏
|
VelikovPetar
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Introduces
media3.exoplayerto thexmlSDK to improve playing of video (and audio) attachments.🛠 Implementation details
androidx.media3:media3-exoplayerandandroidx.media3:media3-uidependencies.AttachmentMediaActivityto userPlayerView+ExoPlayer(instead ofVideoView). Important: Here I kept the appearance of the controls same as the old ones. The reason is that because for audio files, we actually show an 'audio file' image in the middle of it, which is already public and customizable via theStreamUi.MediaActivity.Iconstyle. Removing this would be a breaking change for customers using/customizing this field. We can remove this and align it to the compose implementation in the next major release.🎨 UI Changes
video-before.mp4
video-after.mp4
audio-before.mp4
audio-after.mp4
🧪 Testing