[AND-462] (compose): Replace VideoView with ExoPlayer + PlayerView. #5749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size Comparison 📏
|
added 2 commits
April 28, 2025 09:48
…pose # Conflicts: # CHANGELOG.md
andremion
reviewed
May 5, 2025
...n/java/io/getstream/chat/android/compose/ui/attachments/preview/internal/MediaGalleryPage.kt
Outdated
Show resolved
Hide resolved
...n/java/io/getstream/chat/android/compose/ui/attachments/preview/internal/MediaGalleryPage.kt
Outdated
Show resolved
Hide resolved
...n/java/io/getstream/chat/android/compose/ui/attachments/preview/internal/MediaGalleryPage.kt
Outdated
Show resolved
Hide resolved
...c/main/java/io/getstream/chat/android/compose/ui/attachments/preview/MediaPreviewActivity.kt
Outdated
Show resolved
Hide resolved
...c/main/java/io/getstream/chat/android/compose/ui/attachments/preview/MediaPreviewActivity.kt
Outdated
Show resolved
Hide resolved
added 2 commits
May 5, 2025 15:58
…hem follow the parent Box size (MediaGalleryVideoPage).
andremion
reviewed
May 6, 2025
...o/getstream/chat/android/compose/ui/attachments/preview/internal/StreamVideoPlayerContent.kt
Outdated
Show resolved
Hide resolved
...o/getstream/chat/android/compose/ui/attachments/preview/internal/StreamVideoPlayerContent.kt
Outdated
Show resolved
Hide resolved
...o/getstream/chat/android/compose/ui/attachments/preview/internal/StreamVideoPlayerContent.kt
Outdated
Show resolved
Hide resolved
andremion
approved these changes
May 7, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Introduces
media3.exoplayerto thecomposeSDK to improve playing of video (and audio) attachments.🛠 Implementation details
androidx.media3:media3-exoplayerandandroidx.media3:media3-uidependencies. (There is also a compose artefact (media3-ui-compose), however it is in very early development, and doesn't provide all the options like themedia3-uidoes (fast forward/backward, speed controls, progress indicator...))MediaGalleryVideoPageto usePlayerView+ExoPlayer(instead ofVideoView)MediaAttachmentActivityto userPlayerView+ ExoPlayer (instead ofVideoView)🎨 UI Changes
Add relevant screenshots
before.mp4
after.mp4
before-audio.mp4
after-audio.mp4
🧪 Testing