Skip to content

[FEEDS-993]feeds-v3 noti-trigger-data update, DONt MERGE #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FEEDS-993]feeds-v3 noti-trigger-data update, DONt MERGE #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feeds-v3.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions feeds_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,8 +636,8 @@ func test08AddComment(t *testing.T, ctx context.Context, feedsClient *getstream.
// snippet-start: AddComment
response, err := feedsClient.AddComment(ctx, &getstream.AddCommentRequest{
Comment: getstream.PtrTo("This is a test comment from Go SDK"),
ObjectID: activityID,
ObjectType: "activity",
ObjectID: &activityID,
ObjectType: getstream.PtrTo("activity"),
UserID: &testUserID,
})
// snippet-end: AddComment
Expand Down Expand Up @@ -673,8 +673,8 @@ func test09QueryComments(t *testing.T, ctx context.Context, feedsClient *getstre
// Add a comment first
commentResponse, err := feedsClient.AddComment(ctx, &getstream.AddCommentRequest{
Comment: getstream.PtrTo("Comment for query test"),
ObjectID: activityID,
ObjectType: "activity",
ObjectID: &activityID,
ObjectType: getstream.PtrTo("activity"),
UserID: &testUserID,
})
assertResponseSuccess(t, commentResponse, err, "add comment for query test")
Expand Down Expand Up @@ -712,8 +712,8 @@ func test10UpdateComment(t *testing.T, ctx context.Context, feedsClient *getstre
// Add a comment to update
commentResponse, err := feedsClient.AddComment(ctx, &getstream.AddCommentRequest{
Comment: getstream.PtrTo("Comment to be updated"),
ObjectID: activityID,
ObjectType: "activity",
ObjectID: &activityID,
ObjectType: getstream.PtrTo("activity"),
UserID: &testUserID,
})
assertResponseSuccess(t, commentResponse, err, "add comment for update test")
Expand Down Expand Up @@ -1075,8 +1075,8 @@ func test21DeleteComment(t *testing.T, ctx context.Context, feedsClient *getstre
// Add a comment first
commentResponse, err := feedsClient.AddComment(ctx, &getstream.AddCommentRequest{
Comment: getstream.PtrTo("Comment to be deleted"),
ObjectID: activityID,
ObjectType: "activity",
ObjectID: &activityID,
ObjectType: getstream.PtrTo("activity"),
UserID: &testUserID,
})
assertResponseSuccess(t, commentResponse, err, "add comment for delete test")
Expand Down Expand Up @@ -1591,8 +1591,8 @@ func test32RealWorldUsageDemo(t *testing.T, ctx context.Context, feedsClient *ge
for _, commentText := range comments {
commentResponse, err := feedsClient.AddComment(ctx, &getstream.AddCommentRequest{
Comment: getstream.PtrTo(commentText),
ObjectID: postID,
ObjectType: "activity",
ObjectID: &postID,
ObjectType: getstream.PtrTo("activity"),
UserID: &testUserID2,
})
assertResponseSuccess(t, commentResponse, err, "add comment to post")
Expand Down
77 changes: 76 additions & 1 deletion models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 11 additions & 7 deletions requests.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.