Update Tutorial to SDK 5.2.0 #65

MarinTolic · 2022-05-12T10:53:46Z

Update tutorial to SDK 5.2.0
Update Java tutorial to use OP (part of the 5.2.0 update)
Refactor typing updates logic
Remove a recursive call in the custom imgur viewholder code

Testing

You can use the following patch to make sure typing updates work in ChannelActivity3 and "ChannelActivity4" in both Kotlin and Java apps.

The following patch will change the user to jc, it shares the channel Glaring Bear with user tutorialdroid

Code in a collapsible block

Index: samplekotlin/src/main/java/com/example/chattutorial/MainActivity.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/samplekotlin/src/main/java/com/example/chattutorial/MainActivity.kt b/samplekotlin/src/main/java/com/example/chattutorial/MainActivity.kt
--- a/samplekotlin/src/main/java/com/example/chattutorial/MainActivity.kt	(revision b306a5c8c93c2c03512f3930ef25195c0a0237d3)
+++ b/samplekotlin/src/main/java/com/example/chattutorial/MainActivity.kt	(date 1652355528185)
@@ -45,13 +45,13 @@
 
         // Step 3 - Authenticate and connect the user
         val user = User(
-            id = "tutorial-droid",
-            name = "Tutorial Droid",
+            id = "jc",
+            name = "jc",
             image = "https://bit.ly/2TIt8NR"
         )
         client.connectUser(
             user = user,
-            token = "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjoidHV0b3JpYWwtZHJvaWQifQ.NhEr0hP9W9nwqV7ZkdShxvi02C5PR7SJE7Cs4y7kyqg"
+            token = "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjoiamMifQ.NgHlRrxJhvpfLAY3Q1q23oSayLJKTlXUadhD2l0kKWI"
         ).enqueue()
 
         // Step 4 - Set the channel list filter and order

MarinTolic · 2022-05-12T10:55:55Z

samplejava/src/main/java/com/example/chattutorial/ChannelActivity3.java

+        binding.typingHeaderView.setText(nobodyTyping);
+
+        // Observe typing events and update typing header depending on its state.
+        Flow<ChannelState> channelStateFlow = ChatClientExtensions.watchChannelAsState(ChatClient.instance(), cid, 30);


This is very clunky, but we currently don't expose any of our state classes (ChannelState, GlobalState, ...) as LiveData.

It was either this or suggesting that Java users use Coroutines, which I feel is a bigger unknown in the Java world + the syntax would still be clunky since Flow operators are written as extensions.

MarinTolic · 2022-05-12T10:57:09Z

samplejava/src/main/java/com/example/chattutorial/ChannelActivity3.java

+    // Helper method that transforms typing updates into a string
+    // containing typing member's names
+    @NonNull
+    private String joinTypingUpdatesToUserNames(@NonNull TypingEvent typingEvent) {


We have to do this manually because String.join() is not compatible with Android API 21 without desugaring.

MarinTolic · 2022-05-12T10:58:42Z

samplejava/src/main/java/com/example/chattutorial/ChannelActivity4.java

+        // Set view factory manager for Imgur attachments
+        ImgurAttachmentFactory imgurAttachmentFactory = new ImgurAttachmentFactory();
+
+        List<ImgurAttachmentFactory> imgurAttachmentViewFactories = new ArrayList<ImgurAttachmentFactory>();


Again, List.of() not supported by API 21 without desugaring, making this feel clunky.

MarinTolic · 2022-05-12T11:01:55Z

samplekotlin/src/main/java/com/example/chattutorial/ImgurAttachmentFactory.kt

    override fun createViewHolder(
        message: Message,
        listeners: MessageListListenerContainer?,
        parent: ViewGroup
    ): InnerAttachmentViewHolder {
-        val imgurAttachment = message.attachments.firstOrNull { it.isImgurAttachment() }
-            ?: return createViewHolder(message, listeners, parent)
+        val imgurAttachment = message.attachments.first() { it.isImgurAttachment() }


This should be safe because canHandle has already made sure that this attachment exists.

Also previously this was a recursive call.

MarinTolic · 2022-05-12T11:03:10Z

samplekotlin/src/main/java/com/example/chattutorial/ChannelActivity3.kt

@@ -95,7 +96,10 @@ class ChannelActivity3 : AppCompatActivity() {

        // Observe typing events and update typing header depending on its state.
        lifecycleScope.launchWhenStarted {
-            ChatClient.instance().globalState.typingUpdates.collect {


GlobalState should not be used here. It would provide typing updates not for a particular channel but for all active channels.

In order to get updates for a particular active channel we have to watch it first and collect the resulting ChannelState.

…e imports for Stream resources because shortened imports confuse the IDE when copy pasting

MarinTolic · 2022-05-13T09:50:27Z

samplekotlin/src/main/java/com/example/chattutorial/ImgurAttachmentFactory.kt

@@ -47,12 +47,12 @@ class ImgurAttachmentFactory : AttachmentFactory {
            binding.ivMediaThumb.apply {
                shapeAppearanceModel = shapeAppearanceModel
                    .toBuilder()
-                    .setAllCornerSizes(resources.getDimension(R.dimen.stream_ui_selected_attachment_corner_radius))
+                    .setAllCornerSizes(resources.getDimension(io.getstream.chat.android.ui.R.dimen.stream_ui_selected_attachment_corner_radius))


Not using fully classified names seems to throw the IDE off when copy pasting from our tutorial or even another IDE where the import is working.

Classifying it fully fixes that and should result in the users a smoother experience.

skydoves

Looks good to me! 💯

MarinTolic added 7 commits May 10, 2022 16:59

- Updated applications to SDK 5.1.0

d4c6f40

- Updated applications to SDK 5.1.0

f9b0c6c

- Updated applications to SDK 5.1.0

4c316c2

- Updated applications to SDK 5.2.0

c687504

- Remove linter warnings

b7df9c0

- collapse kdocs

721b418

- collapse kdocs, re-arrange gradle structure

b306a5c

MarinTolic commented May 12, 2022

View reviewed changes

MarinTolic requested review from skydoves and filbabic May 12, 2022 11:03

- Update comments for consistency, change to fully classified resourc…

8c9be54

…e imports for Stream resources because shortened imports confuse the IDE when copy pasting

MarinTolic commented May 13, 2022

View reviewed changes

skydoves approved these changes May 16, 2022

View reviewed changes

filbabic removed their request for review May 17, 2022 09:16

skydoves marked this pull request as ready for review May 22, 2022 23:14

skydoves merged commit 7f1049e into main May 22, 2022

skydoves deleted the update/5.2.0 branch May 22, 2022 23:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update Tutorial to SDK 5.2.0 #65

Update Tutorial to SDK 5.2.0 #65

Uh oh!

MarinTolic commented May 12, 2022 •

edited

Loading

Uh oh!

MarinTolic May 12, 2022

Uh oh!

MarinTolic May 12, 2022 •

edited

Loading

Uh oh!

MarinTolic May 12, 2022

Uh oh!

MarinTolic May 12, 2022

Uh oh!

MarinTolic May 12, 2022

Uh oh!

MarinTolic May 13, 2022 •

edited

Loading

Uh oh!

skydoves left a comment

Uh oh!

Uh oh!

Update Tutorial to SDK 5.2.0 #65

Update Tutorial to SDK 5.2.0 #65

Uh oh!

Conversation

MarinTolic commented May 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Uh oh!

MarinTolic May 12, 2022

Choose a reason for hiding this comment

Uh oh!

MarinTolic May 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MarinTolic May 12, 2022

Choose a reason for hiding this comment

Uh oh!

MarinTolic May 12, 2022

Choose a reason for hiding this comment

Uh oh!

MarinTolic May 12, 2022

Choose a reason for hiding this comment

Uh oh!

MarinTolic May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skydoves left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MarinTolic commented May 12, 2022 •

edited

Loading

MarinTolic May 12, 2022 •

edited

Loading

MarinTolic May 13, 2022 •

edited

Loading