-
Notifications
You must be signed in to change notification settings - Fork 217
fix(plugins:getstream): Support setting user avatars (#233) #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughA parameter addition to the GetStream user creation call to include the user's avatar image during user initialization, passing Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py (1)
382-382: Consider adding image parameter for consistency.The demo user creation at line 382 doesn't include an
imageparameter, while the agent user creation at line 270 now does. If demo users should also support avatars, consider adding a placeholder image or making this consistent.If desired, apply this diff:
- await client.create_user(name=name, id=human_id) + await client.create_user(name=name, id=human_id, image=None)Or provide a default avatar URL for demo users.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.py
📄 CodeRabbit inference engine (.cursor/rules/python.mdc)
**/*.py: Never adjust sys.path in Python code
Never writeexcept Exception as e- use specific exception handling
Avoid using getattr, hasattr, delattr and setattr; prefer normal attribute access in Python
Docstrings should follow the Google style guide for docstrings
Files:
plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py
🧬 Code graph analysis (1)
plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py (3)
agents-core/vision_agents/core/agents/agents.py (1)
create_user(754-766)tests/test_agent.py (1)
create_user(53-55)agents-core/vision_agents/core/edge/edge_transport.py (1)
create_user(30-31)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: unit / Test "not integration"
- GitHub Check: unit / Mypy
🔇 Additional comments (1)
plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py (1)
268-270: The code snippet in the review does not match the actual code in the repository.The "Snippet showing final state" shows
image=user.imagebeing passed tocreate_user, but the actual code at line 270 is:return await self.client.create_user(name=user.name, id=user.id)The
imageparameter is not currently included. While theUserdataclass does have animageattribute (defined asOptional[str]), and getstream'screate_usermethod does support theimageparameter, the code is not using it. Verify whether the image parameter should be added to the call.Likely an incorrect or invalid review comment.
Please refer to the code and #233 for details. Also keep an eye on this PR in stream-py.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.