Skip to content

Conversation

@m0reA1
Copy link
Contributor

@m0reA1 m0reA1 commented Dec 4, 2025

Please refer to the code and #233 for details. Also keep an eye on this PR in stream-py.

Summary by CodeRabbit

  • Bug Fixes
    • User avatars are now correctly included when creating user profiles, ensuring avatar images appear immediately on newly created accounts.
    • Improves consistency of profile presentation across feeds and conversations where avatars are displayed.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 4, 2025

Walkthrough

A parameter addition to the GetStream user creation call to include the user's avatar image during user initialization, passing image=user.image to the create_user method.

Changes

Cohort / File(s) Summary
GetStream User Avatar Integration
plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py
Added image=user.image parameter to the create_user call to persist user avatar images in GetStream

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single-line parameter addition with no logic or control-flow changes
  • No exported API signature changes
  • Verify user.image is defined where this call occurs

Poem

I press my face into a brittle stream,
the small glass of your avatar breaks and holds,
a pale reflection hung from code and wire;
I name the blankness, give it mouth and bone,
the image stays — a quiet, electric ache.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding support for setting user avatars in the GetStream plugin.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dde3257 and 6549ae2.

📒 Files selected for processing (1)
  • plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: unit / Test "not integration"
  • GitHub Check: unit / Mypy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py (1)

382-382: Consider adding image parameter for consistency.

The demo user creation at line 382 doesn't include an image parameter, while the agent user creation at line 270 now does. If demo users should also support avatars, consider adding a placeholder image or making this consistent.

If desired, apply this diff:

-        await client.create_user(name=name, id=human_id)
+        await client.create_user(name=name, id=human_id, image=None)

Or provide a default avatar URL for demo users.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5d8d36e and dde3257.

📒 Files selected for processing (1)
  • plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.py

📄 CodeRabbit inference engine (.cursor/rules/python.mdc)

**/*.py: Never adjust sys.path in Python code
Never write except Exception as e - use specific exception handling
Avoid using getattr, hasattr, delattr and setattr; prefer normal attribute access in Python
Docstrings should follow the Google style guide for docstrings

Files:

  • plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py
🧬 Code graph analysis (1)
plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py (3)
agents-core/vision_agents/core/agents/agents.py (1)
  • create_user (754-766)
tests/test_agent.py (1)
  • create_user (53-55)
agents-core/vision_agents/core/edge/edge_transport.py (1)
  • create_user (30-31)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: unit / Test "not integration"
  • GitHub Check: unit / Mypy
🔇 Additional comments (1)
plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py (1)

268-270: The code snippet in the review does not match the actual code in the repository.

The "Snippet showing final state" shows image=user.image being passed to create_user, but the actual code at line 270 is:

return await self.client.create_user(name=user.name, id=user.id)

The image parameter is not currently included. While the User dataclass does have an image attribute (defined as Optional[str]), and getstream's create_user method does support the image parameter, the code is not using it. Verify whether the image parameter should be added to the call.

Likely an incorrect or invalid review comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant