-
Notifications
You must be signed in to change notification settings - Fork 243
Make wait_for_participant resilient #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe PR bumps the Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Agent
participant StreamConnection
participant ParticipantsState
Agent->>StreamConnection: join(call)
StreamConnection->>StreamConnection: access _connection.participants_state
StreamConnection-->>Agent: return ParticipantsState (participants property)
Agent->>ParticipantsState: subscribe / map(on_participants)
note right of ParticipantsState `#DFF2E1`: participant list updates
ParticipantsState-->>Agent: participant updates (via subscription)
Agent->>Agent: set self.participants = ParticipantsState
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
New Features
Chores