refactor(components): menu item only changes color on focus-visible
#2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying atlantis with
|
| Latest commit: |
3f6d447
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fc7e1403.atlantis.pages.dev |
| Branch Preview URL: | https://update-focus-style-for-menu.atlantis.pages.dev |
chris-at-jobber
commented
Jan 21, 2025
chris-at-jobber
commented
Jan 21, 2025
| text-align: start; | ||
| background-color: transparent; | ||
| cursor: pointer; | ||
| gap: var(--menu-space); |
There was a problem hiding this comment.
This re-order happened via auto-fix
chris-at-jobber
commented
Jan 21, 2025
| @@ -65,24 +65,26 @@ | |||
|
|
|||
| .action { | |||
| display: flex; | |||
| gap: var(--menu-space); | |||
There was a problem hiding this comment.
chris-at-jobber
commented
Jan 21, 2025
| width: 100%; | ||
| padding: var(--menu-space); | ||
| border: none; | ||
| border-radius: var(--radius-base); | ||
| outline: transparent; |
There was a problem hiding this comment.
Beacuse we're using box-shadow on focus, this sets outline to transparent so that high-contrast modes still work.
chris-at-jobber
commented
Jan 21, 2025
| } | ||
|
|
||
| .action:hover, | ||
| .action:focus { | ||
| .action:focus-visible { |
There was a problem hiding this comment.
focus-visible respects browser heuristics for what should and not be focused
This reverts commit 16c2527.
nad182
approved these changes
Jan 22, 2025
Co-authored-by: Nazarii L <nazarii.l@getjobber.com>
chris-at-jobber
commented
Jan 22, 2025
|
@nad182 added it, great suggestion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
Bring the menu items more in line with our overall pattern for focus states.
Changes
Changed
shadow-focusinstead of outline on focus-visibleScreen.Recording.2025-01-21.at.3.20.12.PM.mov
Testing
Open a menu with your mouse vs with your keyboard
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.