Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap notfound template with Layout component #145

Merged
merged 2 commits into from
Feb 23, 2024
Merged

wrap notfound template with Layout component #145

merged 2 commits into from
Feb 23, 2024

Conversation

dgading
Copy link
Member

@dgading dgading commented Feb 23, 2024

fixes #143

The NotFound template just had an H1 with no Layout component wrapping it. This meant the header and footer wouldn't load on the page.

Copy link
Contributor

@brdunfield brdunfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgading dgading merged commit f6206d8 into main Feb 23, 2024
1 check passed
@dgading dgading deleted the notfound-layout branch February 23, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page Not Found is not using Layout
2 participants