Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to work with marionette 1.0.0rc3 #8

Closed
wants to merge 8 commits into from
Closed

Update to work with marionette 1.0.0rc3 #8

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f79d4d2
Upgraded example to use new signature of context.listen
vitch Jan 24, 2013
fb386fc
Upgraded jQuery, underscore and backbone to latest versions and updat…
vitch Jan 24, 2013
3a48728
Updated backbone.marionette and its dependencies and updated the requ…
vitch Jan 24, 2013
2c70a76
Switching out the uses of Backbone.EventBinder for the new listenTo i…
vitch Jan 24, 2013
ce84e18
Using Marionette.addEventBinder to maintain scope in the listenTo met…
vitch Jan 24, 2013
3fb8501
Commenting out a line in the example which pointed to a non-existent …
vitch Jan 24, 2013
cd7ed4f
Bumping the version to avoid confusion...
vitch Jan 24, 2013
013bc35
The stopListening wasn't working as expected.
vitch Jan 25, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Using Marionette.addEventBinder to maintain scope in the listenTo met… 
…hods
  • Loading branch information
@vitch
vitch committed Jan 24, 2013
commit ce84e18de4b005db4e86821bdcf3bd9241fd8bd5
4 changes: 2 additions & 2 deletions backbone.geppetto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ define( [

this.vent = {};

_.extend(this.vent, Backbone.Events);
Marionette.addEventBinder(this.vent);

this.initialize && this.initialize();

Expand Down Expand Up @@ -114,7 +114,7 @@ define( [
}
}

this.vent.listenTo( this.vent, eventName, callback );
this.vent.listenTo( this.vent, eventName, callback, target );
// The arguments to listenTo are enough to stop listening to an event so we'll store those as the binding
var binding = [this.vent, eventName, callback];

Expand Down