Use localhost instead of remote server for network marked tests.#320
Merged
JamesParrott merged 1 commit intoGeospatialPython:masterfrom Jul 20, 2025
Merged
Conversation
Run on this branch Run Network tests in container jobs Remove type field from Action input Add description and required fields to Action input. Add option to Clone repo of copies of files to serve locally in mock remote url tests Specify shell in action job step Use actions/checkout instead of git (unavailable in Python slim docker images) Checkout artefacts repo to .. Add pyshp_repo_directory input Serve artefacts on localhost:8000 Specify shell: bash in Github action Don't curl from localhost - not available in Python slim images (neither is wget) TRy requesting on localhost in Python non-slim images Correct path to custom test file Test local server Sleep for twice as long after starting simple Python server Don't output PyTest version Swap out remote URLs with stripped path localhost version Rename input variable Import re where needed and reformat Reformat Change env var to be yes / no, not True / False Reformat Pass list to urlunparse on Python 2 Specify port 8000 Use double quotes Separate network tests and non-network tests into different steps Trim whitespace Try Network tests on all platforms Print simplified localhost urls during Pytest network tests Reorder pre-commit hooks and add blank line Try curling from simplified url on Python2 Test curl from server only Remove errant ' Run doctests against Python 2 SimpleHTTPServer Special case "import shapefile" in doctests filter Update shapefile.py Always include first example doctest Run Pytest tests in Python 2 non-slim container Update action.yml Update test_shapefile.py Update test_shapefile.py Explicitly export env var Don't need to explicitly set env var. Test without patching localhost. Reformat Update shapefile.py Update shapefile.py Use Caddy instead of SimpleHTTPServer Run caddy in backgorund Run all tests in all containers, all platforms, all Python versions Revert to python -m http.server to avoid overloading Caddy releases page
This was referenced Jul 21, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run on this branch
Run Network tests in container jobs
Remove type field from Action input
Add description and required fields to Action input.
Add option to Clone repo of copies of files to serve locally in mock remote url tests
Specify shell in action job step
Use actions/checkout instead of git (unavailable in Python slim docker images)
Checkout artefacts repo to ..
Add pyshp_repo_directory input
Serve artefacts on localhost:8000
Specify shell: bash in Github action
Don't curl from localhost - not available in Python slim images (neither is wget)
TRy requesting on localhost in Python non-slim images
Correct path to custom test file
Test local server
Sleep for twice as long after starting simple Python server
Don't output PyTest version
Swap out remote URLs with stripped path localhost version
Rename input variable
Import re where needed and reformat
Reformat
Change env var to be yes / no, not True / False
Reformat
Pass list to urlunparse on Python 2
Specify port 8000
Use double quotes
Separate network tests and non-network tests into different steps
Trim whitespace
Try Network tests on all platforms
Print simplified localhost urls during Pytest network tests
Reorder pre-commit hooks and add blank line
Try curling from simplified url on Python2
Test curl from server only
Remove errant '
Run doctests against Python 2 SimpleHTTPServer
Special case "import shapefile" in doctests filter
Update shapefile.py
Always include first example doctest
Run Pytest tests in Python 2 non-slim container
Update action.yml
Update test_shapefile.py
Update test_shapefile.py
Explicitly export env var
Don't need to explicitly set env var. Test without patching localhost.
Reformat
Update shapefile.py
Update shapefile.py
Use Caddy instead of SimpleHTTPServer
Run caddy in backgorund
Run all tests in all containers, all platforms, all Python versions
Revert to python -m http.server to avoid overloading Caddy releases page