NPI-4175 Revise filename property extraction functionality#94
Merged
Conversation
…here to IGS long filename specification, adding option to enforce long filename and error on others
…ies_from_filename() for consistency and interoperability
…rove error handling
…n overly permissive regex
…ps compression flag and station_id. Fix station_id extraction.
ronaldmaj
reviewed
Sep 17, 2025
ronaldmaj
previously approved these changes
Sep 17, 2025
Collaborator
ronaldmaj
left a comment
There was a problem hiding this comment.
I've tested this locally with a couple files I have. Seems to work fine with those. I've also had a look through the code and don't see anything that jumps out as a big issue.
Happy for this to go in, especially as it will help with recent work.
ronaldmaj
approved these changes
Sep 18, 2025
Collaborator
ronaldmaj
left a comment
There was a problem hiding this comment.
The change was an update to a comment - still happy for this to go in 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves robustness and error checking, in functionality for statically extracting properties from filenames.
Notably:
start epochandend epoch, rather than astart epochandperiod).gz) or not. Note that this is technically part of the filename specification. Previously, passing.SP3.gzwould result in an error and had to be trimmed first.