Fix interactive apps on unstable by using odc-geo#1481
Open
Fix interactive apps on unstable by using odc-geo#1481
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cbur24
approved these changes
Apr 15, 2026
Collaborator
cbur24
left a comment
There was a problem hiding this comment.
Many thanks for fixing these apps @robbibt. I've tested each of them on the unstable Sandbox without issue. I added a fix to the wetlands.py file which was also calling the old datacube Geometry function, resulting in the WIT interactive app failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Geometry tooling in ODC were recently relocated from
datacube.utils.geometrytoodc-geo. This has led some of our interactive notebooks to fail when run on the latestunstableSandbox image: #1480This PR fixes three interactive notebooks (animations, image export, filmstrips) by using
odc-geofor geometry operations. For example, replacing this:With this:
Also made some minor styling updates to notebooks that have not been updated for some time, and fixed an issue with the tests to exclude interactive notebooks from the "test changed notebooks" tests (interactive notebooks can't be tested automatically as they require human input).
Closes issues (optional)
Checklist
If this is a notebook, then have you:
Load packagesGeneral advice)jupyterlab_code_formattertool can be used to format code cells to a consistent style: select each code cell, then clickEditand then one of theApply X Formatteroptions (YAPForBlackare recommended).Notebook currently compatible withline below the notebook title to reflect the environments the notebook is compatible with