Skip to content

Fix interactive apps on unstable by using odc-geo#1481

Open
robbibt wants to merge 4 commits intodevelopfrom
fix_interactive_apps
Open

Fix interactive apps on unstable by using odc-geo#1481
robbibt wants to merge 4 commits intodevelopfrom
fix_interactive_apps

Conversation

@robbibt
Copy link
Copy Markdown
Member

@robbibt robbibt commented Apr 14, 2026

Proposed changes

Geometry tooling in ODC were recently relocated from datacube.utils.geometry to odc-geo. This has led some of our interactive notebooks to fail when run on the latest unstable Sandbox image: #1480

This PR fixes three interactive notebooks (animations, image export, filmstrips) by using odc-geo for geometry operations. For example, replacing this:

from datacube.utils.geometry import Geometry

With this:

from odc.geo.geom import Geometry

Also made some minor styling updates to notebooks that have not been updated for some time, and fixed an issue with the tests to exclude interactive notebooks from the "test changed notebooks" tests (interactive notebooks can't be tested automatically as they require human input).

Closes issues (optional)

Checklist

If this is a notebook, then have you:

  • Checked the structure of the notebook follows our DEA-notebooks template
  • Removed any unused Python packages from Load packages
  • Removed any unused/empty code cells
  • Removed any guidance cells (e.g. General advice)
  • Ensured that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Included relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Tested notebook on the DEA Sandbox
  • Cleared all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • If applicable, update the Notebook currently compatible with line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Copy Markdown
Collaborator

@cbur24 cbur24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for fixing these apps @robbibt. I've tested each of them on the unstable Sandbox without issue. I added a fix to the wetlands.py file which was also calling the old datacube Geometry function, resulting in the WIT interactive app failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants