Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a set of available semtypes so users can easily choose the ones they need. #42

Merged
merged 2 commits into from
Apr 29, 2019

Conversation

ldorigo
Copy link
Contributor

@ldorigo ldorigo commented Apr 28, 2019

Having the full list of semantic types along with examples can make it much faster for users to select the ones they are interested in.

…hey need.

Having the full list of semantic types along with examples can make it much faster for users to select the ones they are interested in.
@soldni
Copy link
Member

soldni commented Apr 29, 2019

Very useful -- thank you so much for going through and adding comments. Would you mind merging this list with the list of accepted semtypes, and comment out those that are not on by default? Thanks!

Best,
Luca

@ldorigo
Copy link
Contributor Author

ldorigo commented Apr 29, 2019

Ah, yes, good idea. Will do that.

@soldni
Copy link
Member

soldni commented Apr 29, 2019

thanks!

@soldni soldni merged commit 512fd64 into Georgetown-IR-Lab:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants