Skip to content

fix: metric-check RNG compatibility #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GeorgePearse wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: metric-check RNG compatibility #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion squeeze/umap_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2246,7 +2246,12 @@ def _check_custom_metric(self, metric, kwds, data=None):
# if checking the high-dimensional distance metric, test directly on
# input data so we don't risk violating any assumptions potentially
# hard-coded in the metric (e.g., bounded; non-negative)
indices = rng.integers(0, data.shape[0], 2)
# sklearn's check_random_state returns a legacy RandomState which
# uses `randint`, while numpy's Generator uses `integers`.
if hasattr(rng, "integers"):
indices = rng.integers(0, data.shape[0], size=2)
else:
indices = rng.randint(0, data.shape[0], size=2)
x, y = data[indices]
else:
# if checking the manifold distance metric, simulate some data on a
Expand Down
Loading