Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Better video controls #299

Closed
1 of 4 tasks
bertob opened this issue May 30, 2023 · 2 comments · Fixed by #322
Closed
1 of 4 tasks

[Request]: Better video controls #299

bertob opened this issue May 30, 2023 · 2 comments · Fixed by #322
Labels
enhancement New feature or request

Comments

@bertob
Copy link
Contributor

bertob commented May 30, 2023

Describe the request

image

The video controls could be better, in particular:

  • The huge play icon in the center looks clickable, but it isn't. I'd either make it a button or drop it
  • The video should probably auto-play when you open the media viewer
  • The overlay controls at the bottom are tiny and feel cramped. I'd give them more padding (e.g. 12px all around). Inspector hack:

image

Implementation Details

  • This should be an option in settings.
  • This should be only available to some fediverse backends. (Include which ones on the above field).
  • This is client-only (and shouldn't sync with the instance).
  • This follows the GNOME HIG.
@bertob bertob added the enhancement New feature or request label May 30, 2023
@GeopJr
Copy link
Owner

GeopJr commented May 30, 2023

The huge play icon in the center looks clickable, but it isn't. I'd either make it a button or drop it

Part of GtkVideo (#205, https://gitlab.gnome.org/GNOME/gtk/-/issues/4522 (seems to be waiting designer input))

The video should probably auto-play when you open the media viewer

✅ edit: added as of 9c1bfaf

The overlay controls at the bottom are tiny and feel cramped. I'd give them more padding (e.g. 12px all around)

Also part of GtkVideo, GtkMediaControls, but can be disabled and replaced.

Since Fractal is also using GtkVideo with GtkMediaControls I feel like it might be better to look for a common solution either for libadwaita or gtk directly

edit: Screenshot of a video on Fractal

image

@GeopJr
Copy link
Owner

GeopJr commented Jun 22, 2023

The first issue has been fixed on GTK and it will be available in 4.11.4!
For the media controls I'll override its style

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants