-
Notifications
You must be signed in to change notification settings - Fork 49
[FEAT] Update to ES6 Modules #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zalo
wants to merge
34
commits into
GeometryCollective:master
Choose a base branch
from
zalo:feat-es6-modules
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to unify the Node and Browser Sources...
Something is funny with the sensitivity on TrackballControls..
…rocessing-js into feat-es6-modules
@zalo Thank you for putting in all this effort! This really looks great, the dependencies in the library haven't been updated in a while. We'll test it out soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
geometry-processing-js
to use the ES6 Module Syntax.ES6 Modules offer several notable benefits. They
node
codebase by unifying both Browser and Node implementationsChangelist:
libs
folder with a three.js CDN.All of the examples still work:
https://zalo.github.io/geometry-processing-js/
https://zalo.github.io/geometry-processing-js/projects/geometric-flow/index.html
https://zalo.github.io/geometry-processing-js/projects/discrete-curvatures-and-normals/index.html
https://zalo.github.io/geometry-processing-js/projects/geodesic-distance/index.html
https://zalo.github.io/geometry-processing-js/projects/parameterization/index.html
https://zalo.github.io/geometry-processing-js/projects/vector-field-decomposition/index.html
https://zalo.github.io/geometry-processing-js/projects/poisson-problem/index.html
https://zalo.github.io/geometry-processing-js/projects/discrete-exterior-calculus/index.html
https://zalo.github.io/geometry-processing-js/projects/direction-field-design/index.html
The documentation rebuilds properly automatically inside of a Github Action:
https://zalo.github.io/geometry-processing-js/docs/index.html
And commits get a spiffy new checkmark when they pass the unit tests and documentation builds:

Note:
You'll see that
"use strict";
has been removed from most files. This is because ES6 Modules are always loaded in strict mode, so it became redundant.I took special care in preserving the overall structure and intent of the code. It is my hope that you will see these changes as an unopinionated attempt towards improving the broader accessibility and maintainability of this library.
I'm a big fan of this library and the work that you guys do. Thank you for putting this all together.
@MarkGillespie @rohan-sawhney @keenancrane @GeometryCollective