Skip to content

Comments

ReHMC Walk for sampling correlation matrices#240

Closed
huuphuocle wants to merge 110 commits intoGeomScale:developfrom
huuphuocle:feature/ReHMCWalk
Closed

ReHMC Walk for sampling correlation matrices#240
huuphuocle wants to merge 110 commits intoGeomScale:developfrom
huuphuocle:feature/ReHMCWalk

Conversation

@huuphuocle
Copy link
Contributor

@huuphuocle huuphuocle commented Sep 5, 2022

Hi all,
Here is a PR for reviewing my implementation of ReHMC Walk for Gaussian and Exponential truncated distribution for the two classes CorreSpectra and CorreSpectra_MT from my first PR #233.

@vissarion vissarion requested a review from TolisChal November 2, 2022 10:27
Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with merging. Thanks!

@vissarion
Copy link
Member

@huuphuocle please resolve conflicts so we can merge this PR.

@vissarion
Copy link
Member

Closing this PR since the approach is not correct.
@huuphuocle please feel free to open a discussion on how to implement this feature.

@vissarion vissarion closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants