ReHMC Walk for sampling correlation matrices#240
Closed
huuphuocle wants to merge 110 commits intoGeomScale:developfrom
Closed
ReHMC Walk for sampling correlation matrices#240huuphuocle wants to merge 110 commits intoGeomScale:developfrom
huuphuocle wants to merge 110 commits intoGeomScale:developfrom
Conversation
…uphuocle/volesti into feature/sampling_correlation_matrices
…uphuocle/volesti into feature/sampling_correlation_matrices
vissarion
approved these changes
Nov 2, 2022
Member
vissarion
left a comment
There was a problem hiding this comment.
I am OK with merging. Thanks!
Member
|
@huuphuocle please resolve conflicts so we can merge this PR. |
TolisChal
approved these changes
Dec 9, 2022
Member
|
Closing this PR since the approach is not correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
Here is a PR for reviewing my implementation of ReHMC Walk for Gaussian and Exponential truncated distribution for the two classes CorreSpectra and CorreSpectra_MT from my first PR #233.