Skip to content

Conversation

@ridoo
Copy link
Member

@ridoo ridoo commented Sep 18, 2025

Closes #26

@ridoo ridoo added the bug Something isn't working label Sep 18, 2025
Copy link
Member

@mwallschlaeger mwallschlaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me

@mwallschlaeger
Copy link
Member

When testing this PR i faced the issue that the description and labels are not transferred to the attribute table in geonode.
image

@mwallschlaeger
Copy link
Member

Patching the API is not removing the attribute description and label. So the initial problem is fixed ...

@ridoo
Copy link
Member Author

ridoo commented Sep 19, 2025

Patching the API is not removing the attribute description and label. So the initial problem is fixed ...

Normalizing attribute names now match the layer attributes known by GeoServer. However, it turns out that sync'ing GeoNode state with GeoServer is not possible via GeoNode tools (only the other direction, i.e. GeoServer -> GeoNode -- even when editing the attributes via metadata editor).

However, for now, we do not use set_attributes and store the actual values directly via Attribute model.

I also played around with setting the layer's extent so that GeoServer has some valid boundaries. However, using VRT does not have any effect here, so we'd have to force GeoServer via REST API to calculate the layers boundaries. This, however, can only be done (as far as I know) via PUTting the actual feature type description, optionally passing the recalculate parameter.

@ridoo ridoo merged commit 050b0fe into main Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Uploading a datapackage with Uppercase letters or spaces deletes attribute definition on api.PATCH

3 participants