Skip to content

Conversation

@dwins
Copy link
Contributor

@dwins dwins commented Oct 7, 2010

Work done for http://projects.opengeo.org/CAPRA/ticket/774 . This branch includes a little extra review of the metadata stuff so it would be good to at least get review from Ariel.

@ingenieroariel
Copy link
Member

David, thanks for extending the metadata integration and fixing a few of those silent template bugs. I like the refactor of the xml parsing functions and the profile links everywhere.

I just have a question related to keywords (and the keyword_list method), are we supposed to allow keywords with more than one word, i.e. "World Bank", should we makke the keywords_list function smarter to not split by spaces inside quotes?

In any case the patch looks in pretty good shape to be merged with master.

@dwins
Copy link
Contributor Author

dwins commented Oct 8, 2010

There's lots of ways we could do the split for keywords (I personally think splitting on commas would be more convenient than quote marks, for example). I think we can safely defer that decision to a later release, however (probably 1.0.1).

jj0hns0n referenced this pull request in jj0hns0n/geonode Jul 19, 2012
Vampouille pushed a commit to Vampouille/geonode that referenced this pull request Sep 12, 2017
update httplib2 and dockerfile so that it builds
goudine pushed a commit to goudine/geonode that referenced this pull request Feb 1, 2018
enable karma tests running using node_modules
@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@291304a). Click here to learn what that means.
The diff coverage is 58.24%.

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   41.16%           
=========================================
  Files             ?      178           
  Lines             ?    19565           
  Branches          ?     3227           
=========================================
  Hits              ?     8054           
  Misses            ?    10893           
  Partials          ?      618

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants