-
Notifications
You must be signed in to change notification settings - Fork 1.2k
"Provided by" field in expander on data search is wrong #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…eoNode#774)" This reverts commit 1fc89b5.
This also updates the search results to use the GMD schema instead of CSW.
|
David, thanks for extending the metadata integration and fixing a few of those silent template bugs. I like the refactor of the xml parsing functions and the profile links everywhere. I just have a question related to keywords (and the keyword_list method), are we supposed to allow keywords with more than one word, i.e. "World Bank", should we makke the keywords_list function smarter to not split by spaces inside quotes? In any case the patch looks in pretty good shape to be merged with master. |
|
There's lots of ways we could do the split for keywords (I personally think splitting on commas would be more convenient than quote marks, for example). I think we can safely defer that decision to a later release, however (probably 1.0.1). |
use style name instead of style object
update httplib2 and dockerfile so that it builds
enable karma tests running using node_modules
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=========================================
Coverage ? 41.16%
=========================================
Files ? 178
Lines ? 19565
Branches ? 3227
=========================================
Hits ? 8054
Misses ? 10893
Partials ? 618 |
Work done for http://projects.opengeo.org/CAPRA/ticket/774 . This branch includes a little extra review of the metadata stuff so it would be good to at least get review from Ariel.