Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Replace ERC721Facet with SolidState implementation #99

Merged
merged 4 commits into from
Oct 5, 2022

Conversation

codynhat
Copy link
Member

@codynhat codynhat commented Oct 5, 2022

Description

Use the SolidState implementation of ERC721 instead of our custom one.

Checklist:

  • My commit message follows the Conventional Commits specification
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my code
  • My changes generate no new warnings
  • My PR is rebased off the most recent main or appropriate feature branch
  • My PR is opened against the main or appropriate feature branch

@codynhat codynhat changed the title chore: Replace ERC721Facet with SolidState implementation chore!: Replace ERC721Facet with SolidState implementation Oct 5, 2022
@coveralls
Copy link

coveralls commented Oct 5, 2022

Pull Request Test Coverage Report for Build 3193362230

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+7.7%) to 98.621%

Totals Coverage Status
Change from base Build 3153789369: 7.7%
Covered Lines: 577
Relevant Lines: 579

💛 - Coveralls

@codynhat codynhat merged commit cf709e5 into develop Oct 5, 2022
@codynhat codynhat deleted the chore/solidstate-erc721 branch October 5, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants