Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Reclaimer #55

Merged
merged 15 commits into from
Apr 3, 2022
Merged

WIP Reclaimer #55

merged 15 commits into from
Apr 3, 2022

Conversation

brossetti1
Copy link
Contributor

WIP branch for Reclaimer #51

@brossetti1 brossetti1 self-assigned this Mar 16, 2022
@brossetti1 brossetti1 changed the base branch from main to v1 March 16, 2022 18:31
@brossetti1
Copy link
Contributor Author

brossetti1 commented Mar 16, 2022 •
edited
Loading

important aspects of this so far are:

  1. getting the startTime for the reclaimer - I made this helper on the superapp thinking it marks the timestamp when the currentBid owner defaulted on their payment..

  2. not sure what to do in the claim method since it looks like the superapp already takes care of license.safeTransfer to the new bidder

  3. claimPrice claculation - current logic for the claimPrice calculation

codynhat
codynhat reviewed Mar 16, 2022
View reviewed changes
contracts/ReClaimer.sol Outdated Show resolved Hide resolved
@brossetti1 brossetti1 changed the base branch from v1 to feat/store-sav March 28, 2022 22:16
@brossetti1
Copy link
Contributor Author

@codynhat i updated based on your feedback - wondering if you aggree with these changes:

get correct reclaim start time
Update claimdata for calculating reclaim price

if you agree with these changes - ill move on to writing tests

@codynhat
Copy link
Member

@codynhat i updated based on your feedback - wondering if you aggree with these changes:

get correct reclaim start time Update claimdata for calculating reclaim price

if you agree with these changes - ill move on to writing tests

LGTM! I will merge feat/store-sav before this

@brossetti1 brossetti1 force-pushed the reclaimer branch 3 times, most recently from 669ac05 to 8663876 Compare March 30, 2022 19:45
@brossetti1 brossetti1 marked this pull request as ready for review March 30, 2022 20:05
Base automatically changed from feat/store-sav to v1 March 31, 2022 00:07
@brossetti1 brossetti1 merged commit ed6c4e8 into v1 Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codynhat codynhat codynhat approved these changes

Assignees

@brossetti1 brossetti1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brossetti1 @codynhat