Initial AuctionSuperApp and claim tests #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codynhat
commented
Feb 4, 2022
| @@ -2,5 +2,6 @@ module.exports = { | |||
| mocha: { | |||
| grep: "@skip-on-coverage", // Find everything with this tag | |||
| invert: true, // Run the grep's inverse set. | |||
| enableTimeouts: false, | |||
There was a problem hiding this comment.
This was needed to support Superfluid tests that take longer
|
@brossetti1 I added solidity-coverage awhile back. The coverage results are currently being included in the repo, but maybe they shouldn't? We could ignore coverage results and just have a separate branch that generates them from a CI action or something? |
codynhat
commented
Feb 4, 2022
| return superApp; | ||
| } | ||
|
|
||
| async function claimSuccess() { |
There was a problem hiding this comment.
@brossetti1 Here is an example of performing a claim by creating a flow. This may be useful for your work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation and testing of
AuctionSuperAppIncludes test cases for claiming and should unblock #37
I've created a
v1branch as the main branch to capture the new Superfluid and auction design.