-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Br setup typechain #36
Br setup typechain #36
Conversation
"@types/chai": "^4.3.0", | ||
"@types/mocha": "^9.1.0", | ||
"@types/node": "^17.0.13", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the chain and mocha types to allow the tests to understand the keywords mocha defines (descirbe, etc) - its also recommended by hardhat
@codynhat one thing im noticing about this is how many dependencies it adds - dependencies this adds - anyways, food for thought i guess |
7fe0af7
to
eaef800
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the typechain/
folder include the typescript outputs? Will we include this eventually?
215aa7a
to
b61c872
Compare
@codynhat yeah the
I really like the way the nouns dao has setup their repo - you can see them doing this here:
fyi - i also like how they do their sdk so you can carry contract addresses across repos: thoughts? I can add to the gitignore if you want to slim the files committed down. otherwise, I can include the |
I like that approach. I'm in the middle of writing new tests in typescript and it would already be valuable to have these. The nounsDAO approach looks like a good one to follow. We have a few other projects that need the contracts exported from here, so something like that would be very useful. Feel free to update the repo to be that structure. It can be on this PR or a separate one. |
b61c872
to
65cc005
Compare
I think this will be good once #35 is merged first? |
65cc005
to
3e7582e
Compare
setting up typechain
instructions
after installing typechain run:
npx hardhat clean
npx hardhat compile
this should generate the typed files: