Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: New Versioning Pattern #107

Merged
merged 5 commits into from
Nov 18, 2022
Merged

chore: New Versioning Pattern #107

merged 5 commits into from
Nov 18, 2022

Conversation

codynhat
Copy link
Member

Description

Updates the versioning pattern. The new interfaces in pco-license and registry define all the external functions that the diamond will have, as well as the different versions. If a facet has multiple versions, the latest version will have its external functions defined in one interface, with each version also having their own.

Checklist:

  • My commit message follows the Conventional Commits specification
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my code
  • My changes generate no new warnings
  • My PR is rebased off the most recent main or appropriate feature branch
  • My PR is opened against the main or appropriate feature branch

@coveralls
Copy link

coveralls commented Nov 17, 2022

Pull Request Test Coverage Report for Build 3492904858

  • 25 of 26 (96.15%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 98.352%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/registry/facets/GeoWebParcelFacet.sol 3 4 75.0%
Totals Coverage Status
Change from base Build 3453161905: 0.09%
Covered Lines: 613
Relevant Lines: 617

💛 - Coveralls

@codynhat codynhat merged commit 17fa040 into develop Nov 18, 2022
@codynhat codynhat deleted the chore/version-pattern branch November 18, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants