Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Simple Deployment #103

Merged
merged 6 commits into from
Oct 12, 2022
Merged

build: Simple Deployment #103

merged 6 commits into from
Oct 12, 2022

Conversation

codynhat
Copy link
Member

Description

Removes hardhat-deploy and does a manual Diamond deployment. This should set us up to next do a deployment via a Multisig.

Checklist:

  • My commit message follows the Conventional Commits specification
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my code
  • My changes generate no new warnings
  • My PR is rebased off the most recent main or appropriate feature branch
  • My PR is opened against the main or appropriate feature branch

@coveralls
Copy link

coveralls commented Oct 12, 2022

Pull Request Test Coverage Report for Build 3238614763

  • 12 of 13 (92.31%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 98.338%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/beacon-diamond/BeaconDiamond.sol 4 5 80.0%
Totals Coverage Status
Change from base Build 3200818090: -0.3%
Covered Lines: 565
Relevant Lines: 568

💛 - Coveralls

@codynhat codynhat merged commit 5b9a39c into develop Oct 12, 2022
@codynhat codynhat deleted the build/simple-deploy branch October 12, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants