Actions for 4th and 5th mouse buttons #2258

brunoais · 2021-04-16T15:21:33Z

For now, the 4th and 5th mouse buttons have erratic behavior from misinterpretation as being either 1st or 3rd buttons.

Nowadays, non-basic mice have, at least, 4 buttons, so, for me, makes most sense that those buttons are assigned. In this case, they are assigned based on my perceived difficulty in activating the feature using the mouse and how often used.

Given such, I decided that app switch to be the 4th button and notifications panel to be the 5th button.
These are what I believe to be the best use for these two. The 4th button being the app switch should be close to the no-brainer.
As for the notifications being the 5th, that one is more open for discussion. IMO, the major competitors being:

Notifications panel
Pinch-to-zoom
paste

No more buttons are assigned because SDL doesn't support them.
For now, I would present this way, as a way to start a discussion

Some mouse clicks DOWN are captured for shortcuts, but the matching UP event was still forwarded to the device. Instead, capture both DOWN and UP for shortcuts, and do nothing on UP.

With this change, the actual HOME is handled by Android on UP on the device. This is consistent with the keyboard shortcut (MOD+h) behavior.

The shortcut "back on screen on" is a bit special: the control is requested by the client, but the actual event injection (POWER or BACK) is determined on the device. To properly inject DOWN and UP events for BACK, transmit the action as a control parameter. If the screen is off: - on DOWN, inject POWER (DOWN and UP) (wake up the device immediately) - on UP, do nothing If the screen is on: - on DOWN, inject BACK DOWN - on UP, inject BACK UP A corner case is when the screen turns off between the DOWN and UP event. In that case, a BACK UP event will be injected, so it's harmless. With this change, the actual BACK is handled by Android on UP on the device (instead of DOWN). This is consistent with the keyboard shortcut (Mod+b) behavior.

rom1v · 2021-04-16T17:00:15Z

👍 It's better to bind them to something.

I made some changes on dev to properly handle DOWN and UP events for shortcuts: #2259
Could you review/test, please?

That way, you could properly propagate them in your action_app_switch().

The 4th button being the app switch should be close to the no-brainer.

Yes, I guess.

As for the notifications being the 5th, that one is more open for discussion.

Why not. But it's maybe odd to bind "open navigation panel" but not "close navigation panel".
Maybe MENU (MOD+m), especially because it's the "unlock screen" shortcut?

I'd like other opinions on that (and my mouse has 3 buttons).

(In the future, I would like to implement some kind of shortcut customization. But it's not a priority.)

brunoais · 2021-04-16T19:48:12Z

+1 It's better to bind them to something.

I made some changes on dev to properly handle DOWN and UP events for shortcuts: #2259
Could you review/test, please?

Sure. I will be able to in about 1h.

As for the notifications being the 5th, that one is more open for discussion.

Why not. But it's maybe odd to bind "open navigation panel" but not "close navigation panel".
Maybe MENU (MOD+m), especially because it's the "unlock screen" shortcut?

No need. Just right click (back button) and it closes. No need for a button to close when the back button does that already. I wanted to have a shortcut key to open towards the 2nd menu, when sliding the finger the 2nd time. Maybe I will end up implementing it as a finger slide... Unsure...

I'd like other opinions on that (and my mouse has 3 buttons).

Mine has 7. Unexpected behaviors happen when I try them all.

(In the future, I would like to implement some kind of shortcut customization. But it's not a priority.)

Great. Want me to try that?

brunoais · 2021-04-16T21:41:31Z

Your branch looks good. I rebased this one on the one you did.

app/src/input_manager.c

…leased)

Some mouse clicks DOWN are captured for shortcuts, but the matching UP events were still forwarded to the device. Instead, capture both DOWN and UP for shortcuts, and do nothing on UP. PR #2259 <#2259> Refs #2258 <#2258>

As a consequence of this change, the HOME button is now handled by Android on mouse released. This is consistent with the keyboard shortcut (MOD+h) behavior. PR #2259 <#2259> Refs #2258 <#2258>

The shortcut "back on screen on" is a bit special: the control is requested by the client, but the actual event injection (POWER or BACK) is determined on the device. To properly inject DOWN and UP events for BACK, transmit the action as a control parameter. If the screen is off: - on DOWN, inject POWER (DOWN and UP) (wake up the device immediately) - on UP, do nothing If the screen is on: - on DOWN, inject BACK DOWN - on UP, inject BACK UP A corner case is when the screen turns off between the DOWN and UP event. In that case, a BACK UP event will be injected, so it's harmless. As a consequence of this change, the BACK button is now handled by Android on mouse released. This is consistent with the keyboard shortcut (Mod+b) behavior. PR #2259 <#2259> Refs #2258 <#2258>

Bind APP_SWITCH to button 4 and expand notification panel on button 5. PR #2258 <#2258> Signed-off-by: Romain Vimont <rom@rom1v.com>

rom1v · 2021-04-17T16:06:29Z

Merged into dev: b28adab

Thank you.

Bind APP_SWITCH to button 4 and expand notification panel on button 5. PR #2258 <#2258> Signed-off-by: Romain Vimont <rom@rom1v.com>

rom1v · 2021-04-17T16:26:15Z

Oops, sorry, I changed X2 to RIGHT_CLICK to test locally, and I kept that in the commit. 🤦

I just fixed and force-pushed dev: ~~c4f3a76~~ b9c3f65

Bind APP_SWITCH to button 4 and expand notification panel on button 5. PR Genymobile#2258 <Genymobile#2258> Signed-off-by: Romain Vimont <rom@rom1v.com>

The shortcut "back on screen on" is a bit special: the control is requested by the client, but the actual event injection (POWER or BACK) is determined on the device. To properly inject DOWN and UP events for BACK, transmit the action as a control parameter. If the screen is off: - on DOWN, inject POWER (DOWN and UP) (wake up the device immediately) - on UP, do nothing If the screen is on: - on DOWN, inject BACK DOWN - on UP, inject BACK UP A corner case is when the screen turns off between the DOWN and UP event. In that case, a BACK UP event will be injected, so it's harmless. As a consequence of this change, the BACK button is now handled by Android on mouse released. This is consistent with the keyboard shortcut (Mod+b) behavior. PR #2259 <#2259> Refs #2258 <#2258>

Bind APP_SWITCH to button 4 and expand notification panel on button 5. PR #2258 <#2258> Signed-off-by: Romain Vimont <rom@rom1v.com>

luke-jr · 2021-08-29T02:15:01Z

The 4th button is typically interpreted as "Back" by regular PC applications...

Can we at least have a setting for that normalish behaviour?

brunoais · 2021-08-29T13:43:32Z

Can we at least have a setting for that normalish behaviour?

Because we already have that function assigned to the right click mouse button.
If you prefer the 4th button to be a back button, feel free to make your own build of scrcpy that does that or use some other program that temporarily reassigns buttons.

luke-jr · 2021-08-29T17:30:14Z

Wouldn't it make more sense to support standard behaviours, and have people who want non-standard behaviours reassign things? :/

Switching between right-click and back-click between applications has been a bit confusing since I started using scrcpy.

rom1v · 2021-08-29T17:45:53Z

Switching between right-click and back-click between applications has been a bit confusing since I started using scrcpy.

The reason is that BACK is very useful even if you have a 2-button mouse.

Yes, designing a "reassing buttons" feature could be useful, but it's not done.

123SONIC321 · 2024-06-21T09:38:12Z

How can I customize the 4th and 5th mouse button clicks?

I'm not a programmer, but I think this shouldn't be too difficult to do. If anyone can guide me through the process, that would be great.

brunoais · 2024-06-21T15:57:38Z

How can I customize the 4th and 5th mouse button clicks?

What do you want them to do? The process is different depending on what you want them to mean.

123SONIC321 · 2024-06-22T12:55:56Z

What do you want them to do?

As a habit, I use mouse buttons 4 and 5 to go back and forward. I would like to set button 4 (the one that is used to go back) as the back button, and I don't care what the forward button is set to as I don't use it much.

brunoais · 2024-06-22T15:20:12Z

I would like to set button 4 (the one that is used to go back) as the back button

In that case, you edit here:

https://github.com/Genymobile/scrcpy/pull/2258/files#diff-fd408d3adc5df68bc93e54b8de3830f0e2814ff8e07c581f41f60008f1e4775eR665

Replace that line's code with:

press_back_or_turn_screen_on(im->controller, ACTION_DOWN)

123SONIC321 · 2024-06-22T20:47:50Z

Replace that line's code with

Thanks a lot, but as I mentioned, I sadly don't know anything about coding. I think for this, I should fork this repository, make the change you mentioned, then release it and use it?

Or is there an easier way to do this without having to create a fork?

rom1v · 2024-06-23T19:58:52Z

@123SONIC321 Please read #4877 (comment)

Add a new option --mouse-bind=xxxx. The argument must be exactly 4 characters, one for each secondary click: --mouse-bind=xxxx ^^^^ |||| ||| `- 5th click || `-- 4th click | `--- middle click `---- right click Each character must be one of the following: - `+`: forward the click to the device - `-`: ignore the click - `b`: trigger shortcut BACK (or turn screen on if off) - `h`: trigger shortcut HOME - `s`: trigger shortcut APP_SWITCH - `n`: trigger shortcut "expand notification panel" This deprecates --forward-all-clicks (use --mouse-bind=++++ instead). Refs <#2258 (comment)> PR #5022 <#5022>

Add a new option --mouse-bind=xxxx. The argument must be exactly 4 characters, one for each secondary click: --mouse-bind=xxxx ^^^^ |||| ||| `- 5th click || `-- 4th click | `--- middle click `---- right click Each character must be one of the following: - `+`: forward the click to the device - `-`: ignore the click - `b`: trigger shortcut BACK (or turn screen on if off) - `h`: trigger shortcut HOME - `s`: trigger shortcut APP_SWITCH - `n`: trigger shortcut "expand notification panel" This deprecates --forward-all-clicks (use --mouse-bind=++++ instead). Refs <Genymobile#2258 (comment)> PR Genymobile#5022 <Genymobile#5022>

rom1v added 3 commits April 16, 2021 17:53

Prevent forwarding only mouse UP events

f0f96fb

Some mouse clicks DOWN are captured for shortcuts, but the matching UP event was still forwarded to the device. Instead, capture both DOWN and UP for shortcuts, and do nothing on UP.

Forward DOWN and UP separately for middle-click

5c65f3c

With this change, the actual HOME is handled by Android on UP on the device. This is consistent with the keyboard shortcut (MOD+h) behavior.

Provide action for the extra mouse buttons

fd9a218

brunoais force-pushed the actions_for_extra_buttons branch from 842ca67 to fd9a218 Compare April 16, 2021 21:30

rom1v reviewed Apr 17, 2021

View reviewed changes

app/src/input_manager.c Outdated Show resolved Hide resolved

Only call to expand_notification_panel when button is pressed (not re…

b1af70e

…leased)

rom1v pushed a commit that referenced this pull request Apr 17, 2021

Provide actions for the extra mouse buttons

b28adab

Bind APP_SWITCH to button 4 and expand notification panel on button 5. PR #2258 <#2258> Signed-off-by: Romain Vimont <rom@rom1v.com>

rom1v closed this Apr 17, 2021

rom1v pushed a commit that referenced this pull request Apr 17, 2021

Provide actions for the extra mouse buttons

c4f3a76

Bind APP_SWITCH to button 4 and expand notification panel on button 5. PR #2258 <#2258> Signed-off-by: Romain Vimont <rom@rom1v.com>

rom1v pushed a commit that referenced this pull request Apr 19, 2021

Provide actions for the extra mouse buttons

b9c3f65

Bind APP_SWITCH to button 4 and expand notification panel on button 5. PR #2258 <#2258> Signed-off-by: Romain Vimont <rom@rom1v.com>

rom1v mentioned this pull request Feb 7, 2024

[Feature request] Make full use of five-button mouse #2110

Closed

1 task

rom1v mentioned this pull request Jun 23, 2024

Forward all clicks by default for UHID and AOA #4877

Closed

rom1v mentioned this pull request Jun 24, 2024

Add option to configure mouse bindings #5022

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Actions for 4th and 5th mouse buttons #2258

Actions for 4th and 5th mouse buttons #2258

brunoais commented Apr 16, 2021 •

edited

Loading

rom1v commented Apr 16, 2021

brunoais commented Apr 16, 2021

brunoais commented Apr 16, 2021

rom1v commented Apr 17, 2021

rom1v commented Apr 17, 2021 •

edited

Loading

luke-jr commented Aug 29, 2021

brunoais commented Aug 29, 2021

luke-jr commented Aug 29, 2021

rom1v commented Aug 29, 2021

123SONIC321 commented Jun 21, 2024

brunoais commented Jun 21, 2024

123SONIC321 commented Jun 22, 2024

brunoais commented Jun 22, 2024

123SONIC321 commented Jun 22, 2024

rom1v commented Jun 23, 2024

Actions for 4th and 5th mouse buttons #2258

Actions for 4th and 5th mouse buttons #2258

Conversation

brunoais commented Apr 16, 2021 • edited Loading

rom1v commented Apr 16, 2021

brunoais commented Apr 16, 2021

brunoais commented Apr 16, 2021

rom1v commented Apr 17, 2021

rom1v commented Apr 17, 2021 • edited Loading

luke-jr commented Aug 29, 2021

brunoais commented Aug 29, 2021

luke-jr commented Aug 29, 2021

rom1v commented Aug 29, 2021

123SONIC321 commented Jun 21, 2024

brunoais commented Jun 21, 2024

123SONIC321 commented Jun 22, 2024

brunoais commented Jun 22, 2024

123SONIC321 commented Jun 22, 2024

rom1v commented Jun 23, 2024

brunoais commented Apr 16, 2021 •

edited

Loading

rom1v commented Apr 17, 2021 •

edited

Loading