Rebase of --serve commits onto v1.16 #1659
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r3pwn
changed the title
Author
|
I'm using @rom1v's suggestion of testing using VLC and it does appear to work for a bit. I had it crash on me once, but haven't been able to reproduce. Additionally, the device window is also visible, which I would classify as a bug. Looking into it |
Collaborator
Good idea 👍
You should never merge a branch in a PR (just rebase instead) 😉 |
added 4 commits
August 10, 2020 19:59
This commit combines the following commits: - Adding --serve option on README - Adding --serve option : Add current working files - Update --serve option with scrcpy v1.13 + Cleaning code. - Fix missing char and error - Allowing other ip address by converting it to hex Rebased on top of the v1.16 source
Author
|
@rom1v My bad, I have resolved that and properly rebased it |
r3pwn
changed the title
Author
|
After some more testing, I haven't been able to reproduce that crash I initially saw, and I realized if I want the display to not appear, it's possible to pass in |
Author
|
@rom1v Have you had the chance to take a look at this PR? |
Collaborator
|
Please read #1419 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of the "--serve commits" ( #1419 ) onto the latest master branch, with all merge issues resolved.
Still seems to be a bit buggy, but this at least puts it on the most recent master branch cleanly