Skip to content

test(launcher): make Windows execution and interruption fixtures faithful - #2050

Draft
dnlrsls wants to merge 1 commit into
test/path-fence-filesystem-fixturesfrom
test/path-fence-launcher-fixtures
Draft

dnlrsls wants to merge 1 commit into
test/path-fence-filesystem-fixturesfrom
test/path-fence-launcher-fixtures

Conversation

@dnlrsls

@dnlrsls dnlrsls commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

PR Type

  • Maintenance/tooling (type:chore)

Summary

Adapt only fixture-owned Node mocks on Windows, preserving native missing/nonfixture/POSIX commands. Model Windows SIGINT delivery through private fixture IPC; retain normal exit130, no Pi launch and provisioning-child termination. POSIX still sends actual signals.

Changes

Edit surface Outcome
tests/gentle-shell-bin.test.ts; tests/node-executable-fixture.test.ts; tests/support/node-executable-fixture.cjs; docs/launcher-test-fixtures.md launcher work unit

Test Plan

Independent122/1/8 with isolation failure; authorized targeted correction1/1 resolves absence/PATH proof. Interrupt exit130/signal-null/no-Pi/child-ESRCH passes independently. Helper passes;8 existing skips unchanged.

Chain Context

Field Value
Chain path-fence safety follow-ups
Tracker PR #2048 (draft/no-merge)
Position 2 of3
Base test/path-fence-filesystem-fixtures
Depends on #2049; #1610 approved pin
Follow-up #2051 security
Review budget 149 /400
Starts at immediate parent branch; inherited foundation excluded
Ends with launcher unit commit 2916bbec15389558af12582bba36a119930d79be
#1610 approved pin -> #2048 tracker
  #2049 filesystem
    📍 #2050 launcher
      #2051 security

Scope / rollback / autonomy

Includes only launcher unit and accompanying tests/docs. Rollback reverts this unit's listed files/commit without reverting prior slices. Excludes new production launcher/history/registry changes, unclassified corpus fixes, merge and automatic base update. CI expected-green is NOT asserted; drafts remain blocked from integration until CI/base decisions.

Linked Issue

Closes #1660
Related: #1659 (primary fix is inherited from #1610, not authored here). Both issues retain status:approved.

Verification limits

Contributor Checklist

  • Linked approved issue and added exactly one matching type label.
  • Conventional commits; no Co-Authored-By trailers.
  • Tests/docs accompany their behavior; no production launcher/history/registry changes in fixture units.
  • Modified-shell/skill checks: N/A, none modified.
  • Complete CI green and base reconciled before merge.

@dnlrsls dnlrsls added the type:chore Maintenance, tooling, tests, build, or CI changes label Oct 10, 2026
@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:chore Maintenance, tooling, tests, build, or CI changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant