Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
type:chore)Summary
Adapt only fixture-owned Node mocks on Windows, preserving native missing/nonfixture/POSIX commands. Model Windows SIGINT delivery through private fixture IPC; retain normal exit130, no Pi launch and provisioning-child termination. POSIX still sends actual signals.
Changes
Test Plan
Independent122/1/8 with isolation failure; authorized targeted correction1/1 resolves absence/PATH proof. Interrupt exit130/signal-null/no-Pi/child-ESRCH passes independently. Helper passes;8 existing skips unchanged.
Chain Context
test/path-fence-filesystem-fixtures2916bbec15389558af12582bba36a119930d79beScope / rollback / autonomy
Includes only launcher unit and accompanying tests/docs. Rollback reverts this unit's listed files/commit without reverting prior slices. Excludes new production launcher/history/registry changes, unclassified corpus fixes, merge and automatic base update. CI expected-green is NOT asserted; drafts remain blocked from integration until CI/base decisions.
Linked Issue
Closes #1660
Related: #1659 (primary fix is inherited from #1610, not authored here). Both issues retain
status:approved.Verification limits
pnpm testwas stopped with181 provisional failure records, without a final summary. Remaining corpus is unclassified; no blanket inherited-failure or full-suite-green claim.tests/gentle-agents.test.ts:5430(ENOTEMPTY); its other jobs pass. Cause not classified; no retry or source correction. Chain integration remains blocked.e262890dcb5f69ff6b7289f7baa491ec72a9bc03; this chain retains the explicitly approved pin162c9bda89242a73f5ed55d7383a8d96ad19660d. Reconcile the base before integration.Contributor Checklist