Skip to content

fix(deps): make pi-tui a peer dependency to use the host copy - #2030

Open
luis11558 wants to merge 1 commit into
Gentleman-Programming:mainfrom
luis11558:fix/pi-tui-peer-dependency
Open

luis11558 wants to merge 1 commit into
Gentleman-Programming:mainfrom
luis11558:fix/pi-tui-peer-dependency

Conversation

@luis11558

@luis11558 luis11558 commented Oct 10, 2026 •

Copy link
Copy Markdown

Summary

  • Move @earendil-works/pi-tui from dependencies (pinned 0.85.1) to peerDependencies (*), so the extension uses the pi-tui copy provided by the host instead of bundling its own.
  • Removes the extension loader warning shown when the host runs a different pi-tui version (observed with host pi-tui 1.1.0 vs bundled 0.85.1).

Changes

File Change
package.json @earendil-works/pi-tui moved to peerDependencies with *
pnpm-lock.yaml Regenerated with pnpm install --lockfile-only

Test Plan

  • pi interactive mode loads the extension and processes prompts with the host-provided pi-tui.
  • Confirm the version-mismatch loader warning is gone (not re-checked after this change).

Summary by CodeRabbit

  • Chores
    • The package no longer installs a specific version of the terminal UI library directly; compatible versions are now provided by the consuming application.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 6ab6b41b-d628-4ba9-8e80-a0f1da917589


📥 Commits

Reviewing files that changed from the base of the PR and between 95c618a and 6306bca.



⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !pnpm-lock.yaml


📒 Files selected for processing (1)
  • package.json


Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.




📝 Walkthrough
📝 Walkthrough

Walkthrough

The package manifest removes the pinned @earendil-works/pi-tui dependency and adds it as a wildcard peer dependency. It retains @heyhuynhgiabuu/pi-pretty as a dependency and keeps typebox as a wildcard peer dependency.

Changes

Dependency update

Layer / File(s) Summary
Peer dependency declaration
package.json
The manifest replaces the pinned @earendil-works/pi-tui dependency with a wildcard peer dependency. @heyhuynhgiabuu/pi-pretty remains a dependency, and typebox remains a wildcard peer dependency.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: alan-thegentleman



Merge Risk: ⚪ Minimal · up to 6306b

The inspected supported host releases provide the pi-tui APIs this extension uses. No concrete current loading failure remains, so the change is ready for normal checks.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: moving pi-tui to a peer dependency so the extension uses the host copy.

✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch fix/pi-tui-peer-dependency


🧪 Generate unit tests (beta)
  • Create a new PR



  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant