Skip to content

Disable pylint 2.7.0 duplicate-code warning #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2021
Merged

Disable pylint 2.7.0 duplicate-code warning #947

merged 1 commit into from
Feb 21, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented Feb 21, 2021 •
edited
Loading

Description of proposed changes

pylint 2.7.0 raises a lot of duplicate-code warnings. This PR disables the duplicate-code check.

Fixes #946.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Feb 21, 2021
@seisman seisman added this to the 0.3.1 milestone Feb 21, 2021
@seisman seisman requested a review from weiji14 February 21, 2021 21:40
weiji14
weiji14 approved these changes Feb 21, 2021
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure on Ubuntu appears unrelated (codecov time out), so ok.

@seisman seisman merged commit d849130 into master Feb 21, 2021
@seisman seisman deleted the pylint-disable-duplicate-code branch February 21, 2021 22:00
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
Disable pylint 2.7.0 duplicate-code warning (GenericMappingTools#947)
1d1c187 
pylint 2.7.0 raises a lot of duplicate-code warnings. This PR disables the duplicate-code check.

Fixes GenericMappingTools#946.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.3.1
Development

Successfully merging this pull request may close these issues.

pylint 2.7.0 breaks the style check
2 participants
@seisman @weiji14