pygmt.grdlandmask: Refactor to use the new alias system for bordervalues/maskvalues #4031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the grdlandmask function to use the new alias system for handling bordervalues and maskvalues parameters instead of the previous manual sequence joining approach.
- Replaces
sequence_joinwith the newAliasSystemandAliasclasses - Updates parameter handling to use the alias system's built-in validation and formatting
- Removes manual parameter processing in favor of the standardized alias approach
Comments suppressed due to low confidence (1)
pygmt/src/grdlandmask.py:16
- The
sequence_joinimport is being removed but is still used in line 122. This will cause an ImportError at runtime.
kwargs_to_strings,
1cfb4ab to
00f0919
Compare
seisman
force-pushed
the
refactor/grdlandmask
branch
from
00f0919 to
7164163
Compare
seisman
added
final review call
michaelgrund
approved these changes
Aug 1, 2025
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new alias system, changes in PR #3963 is no longer needed.
Preview: https://pygmt-dev--4031.org.readthedocs.build/en/4031/api/generated/pygmt.grdlandmask.html