Skip to content

Upgrade the minimum required gmt version to 6.0.0rc5 #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 23, 2019

Description of proposed changes

Upgrade the minimum required gmt version to 6.0.0rc5, which is the last release candidate before 6.0.0.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman requested a review from a team October 23, 2019 23:42
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @seisman, let's get this merged and get on with the legend wrapper @liamtoney!

@seisman seisman merged commit ca9d05f into master Oct 24, 2019
@seisman seisman deleted the gmt6.0.0rc5 branch October 24, 2019 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants