Skip to content

Revert "Pin fsspec to 2022.11.0 as a workaround for upstream dvc issues (#2338)" (#2339 #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Jan 30, 2023

Description of proposed changes

This PR reverts the changes in #2338.

This PR is marked as WIP because the upstream dvc issues are not fixed. Need to trigger the tests to see if there are any progress.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Jan 30, 2023
@seisman seisman added this to the 0.9.0 milestone Jan 30, 2023
@seisman seisman changed the title WIP: Revert "Pin fsspec to 2022.11.0 as a workaround for upstream dvc issues (#2338)" Revert "Pin fsspec to 2022.11.0 as a workaround for upstream dvc issues (#2338)" Feb 11, 2023
@seisman seisman requested a review from weiji14 February 11, 2023 05:21
@seisman
Copy link
Member Author

seisman commented Feb 11, 2023

The upstream dvc-related issue has been fixed and now all tests pass without pinning fsspec.

@seisman seisman added the needs review This PR has higher priority and needs review. label Feb 11, 2023
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seisman, feel free to ping me if dvc acts up again. The dvc conda-forge package has been a bit behind because they have so many sub-packages to keep in sync, and I've been trying to catch up to it at conda-forge/dvc-feedstock#324.

@seisman seisman removed the needs review This PR has higher priority and needs review. label Feb 11, 2023
@seisman seisman changed the title Revert "Pin fsspec to 2022.11.0 as a workaround for upstream dvc issues (#2338)" Revert "Pin fsspec to 2022.11.0 as a workaround for upstream dvc issues (#2338)" (#2339 Feb 11, 2023
@seisman seisman merged commit dccb1c3 into main Feb 11, 2023
@seisman seisman deleted the unpin-fsspec branch February 11, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants