Skip to content

load_earth_relief now can load gebco, gebcosi and synbath datasets with GMT 6.3 #2281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 29, 2022
Merged

load_earth_relief now can load gebco, gebcosi and synbath datasets with GMT 6.3 #2281

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e7a24da
load_earth_relief now can load gebco, gebcosi and synbath datasets wi…
seisman Dec 28, 2022
9b4f487
Temporarily enable tests with GMT 6.3
seisman Dec 28, 2022
061c468
Revert "Temporarily enable tests with GMT 6.3"
seisman Dec 28, 2022
bd4d7b1
Merge branch 'main' into gmt-6.3-gebco-synbath
seisman Dec 28, 2022
b9a949a
Remove unused imports
seisman Dec 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions pygmt/datasets/earth_relief.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@

The grids are available in various resolutions.
"""
from packaging.version import Version
from pygmt.clib import Session
from pygmt.datasets.load_remote_dataset import _load_remote_dataset
from pygmt.exceptions import GMTInvalidInput, GMTVersionError
from pygmt.exceptions import GMTInvalidInput
from pygmt.helpers import kwargs_to_strings

__doctest_skip__ = ["load_earth_relief"]
Expand Down Expand Up @@ -134,13 +132,6 @@ def load_earth_relief(
f"Invalid earth relief 'data_source' {data_source}, "
"valid values are 'igpp', 'gebco', 'gebcosi' and 'synbath'."
)
if data_source != "igpp":
with Session() as lib:
if Version(lib.info["version"]) < Version("6.4.0"):
raise GMTVersionError(
f"The {data_source} option is not available for GMT"
" versions before 6.4.0."
)
# Choose earth relief data prefix
if use_srtm and resolution in land_only_srtm_resolutions:
if data_source == "igpp":
Expand Down