Use Black for code formatting #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following PEP8 is a bit annoying and requires a lot of hand formatting. Black automatically formats code following PEP8 with few exceptions. Most notably the line length is 88 instead of 80, which is actually a lot better. Use `black` to format all our code and adjust the CI configurations to match. Removed the `pep8` and `lint` targets from the `Makefile` (only `check` exists now since black is very fast). Introduces the `format` target to run black on the entire code. Now we don't need to check for PEP8, just run `make format` and everything will be fine. We run the checks on the CI to make sure black was run on the code.
|
@seisman just a heads-up on the changes in PR. It's not a big change and I hope it'll make things easier in the long run. |
6 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PEP8 is a bit annoying and requires a lot of hand formatting.
Black automatically formats code following PEP8 with few exceptions.
Most notably the line length is 88 instead of 80, which is actually a
lot better.
Use
blackto format all our code and adjust the CI configurations tomatch.
Removed the
pep8andlinttargets from theMakefile(onlycheckexists now since black is very fast).
Introduces the
formattarget to run black on the entire code.Now we don't need to check for PEP8, just run
make formatandeverything will be fine.
We run the checks on the CI to make sure black was run on the code.