Skip to content

Remove the GMT6.0 dependency information from README #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2022
Merged

Remove the GMT6.0 dependency information from README #1826

merged 1 commit into from
Mar 18, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 17, 2022 •
edited
Loading

Description of proposed changes

We rely heavily on new features that have been implemented in GMT 6.0. In particular,
a new modern execution mode that greatly simplifies figure creation. These features
are not available in the 5.4 version of GMT.

I'd like to remove the above sentence from the README file, due to the following reasons:

  1. PyGMT now relies on GMT 6.3, so the sentence gives misleading information
  2. We already have a compatibility table at the end of the README file, so no need to mention that PyGMT doesn't work with GMT 5.4 here
  3. This sentence mentions the GMT6 modern execution mode. It makes little sense to users who never used GMT and may cause more confusion.

@seisman seisman marked this pull request as ready for review March 17, 2022 13:33
@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Mar 17, 2022
@seisman seisman added this to the 0.6.1 milestone Mar 17, 2022
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Mar 17, 2022
@seisman seisman merged commit 8fe2d33 into main Mar 18, 2022
@seisman seisman deleted the readme-gmt-dependency branch March 18, 2022 04:14
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 18, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
Remove the GMT6.0 dependency information from README (GenericMappingT…
184914b 
…ools#1826)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrjones maxrjones maxrjones approved these changes

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@seisman @maxrjones @weiji14