Skip to content

Change test_grdview.py to use static_earth_relief #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 21, 2022

Conversation

willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented Feb 13, 2022

This modifies test_grdview.py to use load_static_earth_relief. It also removes the test test_grdview_grid_file_with_region_subset().

Addresses #1684

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Feb 13, 2022
@willschlitzer willschlitzer added this to the 0.6.0 milestone Feb 13, 2022
@willschlitzer willschlitzer self-assigned this Feb 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2022

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
deleted pygmt/tests/baseline/test_grdview_grid_file_with_region_subset.png
modified pygmt/tests/baseline/test_grdview_drapegrid_dataarray.png
modified pygmt/tests/baseline/test_grdview_grid_dataarray.png
modified pygmt/tests/baseline/test_grdview_on_a_plane.png
modified pygmt/tests/baseline/test_grdview_on_a_plane_styled_with_facadepen.png
modified pygmt/tests/baseline/test_grdview_on_a_plane_with_colored_frontal_facade.png
modified pygmt/tests/baseline/test_grdview_surface_mesh_plot_styled_with_meshpen.png
modified pygmt/tests/baseline/test_grdview_surface_plot_styled_with_contourpen.png
modified pygmt/tests/baseline/test_grdview_with_cmap_for_image_plot.png
modified pygmt/tests/baseline/test_grdview_with_cmap_for_perspective_surface_plot.png
modified pygmt/tests/baseline/test_grdview_with_cmap_for_surface_monochrome_plot.png
modified pygmt/tests/baseline/test_grdview_with_perspective.png
modified pygmt/tests/baseline/test_grdview_with_perspective_and_zaxis_frame.png
modified pygmt/tests/baseline/test_grdview_with_perspective_and_zscale.png
modified pygmt/tests/baseline/test_grdview_with_perspective_and_zsize.png

Image diff(s)

Added images

Modified images

Path Old New
test_grdview_drapegrid_dataarray.png
test_grdview_grid_dataarray.png
test_grdview_on_a_plane.png
test_grdview_on_a_plane_styled_with_facadepen.png
test_grdview_on_a_plane_with_colored_frontal_facade.png
test_grdview_surface_mesh_plot_styled_with_meshpen.png
test_grdview_surface_plot_styled_with_contourpen.png
test_grdview_with_cmap_for_image_plot.png
test_grdview_with_cmap_for_perspective_surface_plot.png
test_grdview_with_cmap_for_surface_monochrome_plot.png
test_grdview_with_perspective.png
test_grdview_with_perspective_and_zaxis_frame.png
test_grdview_with_perspective_and_zscale.png
test_grdview_with_perspective_and_zsize.png

Report last updated at commit c0413f8

Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
@maxrjones maxrjones added the final review call This PR requires final review and approval from a second reviewer label Feb 20, 2022
@seisman seisman merged commit 86377f9 into main Feb 21, 2022
@seisman seisman deleted the static-earth-relief/grdview branch February 21, 2022 13:41
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 18, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…s#1752)

Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants