Skip to content

Add a test to check the incols parameter works for vector inputs #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Jan 3, 2022

Description of proposed changes

Closes #1313.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman mentioned this pull request Jan 3, 2022
31 tasks
@seisman seisman added the maintenance Boring but important stuff for the core devs label Jan 3, 2022
@seisman seisman added this to the 0.6.0 milestone Jan 3, 2022
@seisman seisman added the skip-changelog Skip adding Pull Request to changelog label Jan 3, 2022
Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Jan 4, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 5, 2022
@seisman seisman merged commit de655c0 into main Jan 5, 2022
@seisman seisman deleted the vector-incols branch January 5, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "incols" (-i) parameter doesn't works for vector input correctly
3 participants