Reinstall optional geopandas dependency on CI tests #1331
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,7 +83,7 @@ jobs: | |
| # Install dependencies from conda-forge | ||
| - name: Install dependencies | ||
| run: | | ||
| conda install ninja cmake libblas libcblas liblapack fftw gdal geopandas \ | ||
|
There was a problem hiding this comment. Unpinning gdal here should fix the failing GMT Dev Tests on Windows (that have been failing for months now, e.g. at https://github.com/GenericMappingTools/pygmt/runs/2811637685?check_suite_focus=true#step:16:18) by installing the GMT 6.3.0 dev version. However, this will need to wait until conda-forge/gmt-feedstock#154 is merged. |
||
| ghostscript libnetcdf hdf5 zlib curl pcre make dvc | ||
| pip install --pre numpy pandas xarray netCDF4 packaging \ | ||
| ipython pytest-cov pytest-mpl pytest>=6.0 sphinx-gallery | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like
geopandason conda-forge split into two packages in conda-forge/geopandas-feedstock#90. There isgeopandas-base(light version) andgeopandas(full version). An option might be to installgeopandas-baseandfiona(needed for doing I/O, c.f. #1000) instead of the fullgeopandaspackage (which brings in stuff likertreeandmapclassifythat we probably don't need). Or we could keep things as is and just installgeopandassince that's what most users would do.