Skip to content

Remove more xfail from solar tests for GMT 6.2.0rc2 #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2021
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented May 27, 2021

Description of proposed changes

The solar tests now pass with GMT 6.2.0rc2.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels May 27, 2021
@seisman seisman added this to the 0.4.0 milestone May 27, 2021
@seisman seisman requested a review from willschlitzer May 27, 2021 16:43
@weiji14 weiji14 mentioned this pull request May 27, 2021
13 tasks
@seisman
Copy link
Member Author

seisman commented May 28, 2021

Ping @GenericMappingTools/pygmt-maintainers for review.

@seisman seisman merged commit a847292 into master May 28, 2021
@seisman seisman deleted the xfail/solar branch May 28, 2021 20:27
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants