Skip to content

Conda install gmt dev version directly in one step instead of two #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2021

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented May 20, 2021

Description of proposed changes

See if the dependency resolver works better if we install GMT dev and NumPy et al. directly in one conda install step, instead of having a two step process. Helps to resolve the conda dependency resolver issue reported in #1278.

Fixes #1278 🤞, Patches #1218

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

See if the dependency resolver works better if we install
GMT dev and NumPy et al. directly in one `conda install`
step, instead of having a two step process.
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels May 20, 2021
@weiji14 weiji14 self-assigned this May 20, 2021
@weiji14 weiji14 marked this pull request as ready for review May 20, 2021 06:36
@@ -89,8 +89,8 @@ jobs:
# Install GMT and other required dependencies from conda-forge
- name: Install dependencies
run: |
conda install -c conda-forge/label/dev gmt=6.2.0rc1
conda install numpy=${{ matrix.numpy-version }} \
conda install conda-forge/label/dev::gmt=6.2.0rc1 \
Copy link
Member Author

@weiji14 weiji14 May 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to find any mention of the double colon :: way of specifying channels for a single package at https://docs.conda.io/projects/conda/en/latest/commands/install.html, but I know it works and the "Install dependencies" step passes at https://github.com/GenericMappingTools/pygmt/runs/2627248691?check_suite_focus=true#step:5:1, so ... it should be ok?

Edit: Nevermind, found it in the conda v4.4.0 changelog at https://github.com/conda/conda/blob/4.10.1/CHANGELOG.md#new-feature-highlights-2 (see enhanced package query language). The format they use is (channel::)name(version(build_string))

@seisman seisman added this to the 0.4.0 milestone May 20, 2021
@weiji14 weiji14 merged commit e92c0db into master May 20, 2021
@weiji14 weiji14 deleted the conda-install-fix branch May 20, 2021 19:02
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…nericMappingTools#1279)

See if the dependency resolver works better if we install
GMT dev and NumPy et al. directly in one `conda install`
step, instead of having a two step process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux Python 3.9/NumPy 1.20 tests fail at dependency install step due to GDAL 3.3.0?
2 participants