Fix sharedir path #983
Merged
Fix sharedir path #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work in progrress on this.
|
@leouieda Can you check if this commit works in conda builds. |
|
Running at https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=43123 I'll post here when it finishes building |
Also read
|
OK, all checks pass on all 3 OSs. This is good to go on the conda side. |
|
This PR is OK to me. The only tiny issue is that the bundle will still try to search Paul's path first. Of course, Paul's path doesn't exist in users' computer, then the bundle skip it to the correct path. |
|
Maybe we can make this better after rc1 is done. |
|
👍 I'm in favor of that |
|
Yes, I agree. I also don't think my PR is good enough. |
seisman
approved these changes
Jun 19, 2019
This was referenced Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progrress on this.