Skip to content

Set column order for GMT_IS_REFERENCE|GMT_VIA_VECTOR #5989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Conversation

maxrjones
Copy link
Member

Description of proposed changes

The column order was not set correctly for the GMT_IS_REFERENCE|GMT_VIA_VECTOR case. This is meant to fix that. GMT and PyGMT tests pass.

Fixes GenericMappingTools/pygmt#1440, relates to #5392

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PaulWessel PaulWessel merged commit 635985f into master Nov 12, 2021
@PaulWessel PaulWessel deleted the i-col-order branch November 12, 2021 20:22
@maxrjones maxrjones added the bug Something isn't working label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The incols parameter does not always work for pandas.DataFrame
2 participants