Add GetDriversFromDirectoryAsync for local driver discovery by Copilot · Pull Request #142 · GeneralLibrary/GeneralUpdate

Copilot · 2026-02-09T09:22:21Z

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…om local directory Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>

Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>

…e parsing Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>

JusterZhu · 2026-02-09T09:33:42Z

@copilot Translate all the annotations into English.

Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>

Copilot · 2026-02-09T09:46:11Z

@copilot Translate all the annotations into English.

All Chinese annotations have been translated to English. The changes include:

IGeneralDrivelution.cs: Translated all XML documentation (method summaries, parameters, returns)
GeneralDrivelution.cs: Translated class documentation, method summaries, and property descriptions
Implementation files: Translated helper method documentation (Windows, Linux)

All bilingual (Chinese / English) comments have been converted to English-only format.

Implemented in commit 7ddd2f1.

Copilot

Pull request overview

Adds a new API for discovering driver metadata from a local directory across platforms, wiring it through the public entry point and platform implementations, plus accompanying unit tests and English-only documentation updates.

Changes:

Added GetDriversFromDirectoryAsync to IGeneralDrivelution and exposed it via GeneralDrivelution.
Implemented directory-based driver discovery for Windows (*.inf) and Linux (*.ko + optional *.deb/*.rpm), with a macOS stub.
Added unit tests for directory discovery scenarios.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`src/c#/GeneralUpdate.Drivelution/Windows/Implementation/WindowsGeneralDrivelution.cs`	Implements Windows directory scanning/parsing for driver metadata and signature/publisher extraction.
`src/c#/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs`	Implements Linux directory scanning/parsing for kernel modules and packages, using external commands for metadata.
`src/c#/GeneralUpdate.Drivelution/MacOS/Implementation/MacOsGeneralDrivelution.cs`	Adds a not-yet-supported stub implementation of the new method.
`src/c#/GeneralUpdate.Drivelution/GeneralDrivelution.cs`	Exposes the new directory discovery method on the unified static entry point; doc comment translation cleanup.
`src/c#/GeneralUpdate.Drivelution/Abstractions/IGeneralDrivelution.cs`	Adds the new API to the core interface; doc comment translation cleanup.
`src/c#/DrivelutionTest/GeneralDrivelutionTests.cs`	Adds tests for directory discovery behavior (non-existent, empty, basic discovery, pattern, cancellation).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-09T09:57:56Z

src/c#/DrivelutionTest/GeneralDrivelutionTests.cs

+    /// <summary>
+    /// Tests that GetDriversFromDirectoryAsync with search pattern filters correctly.
+    /// </summary>
+    [Fact]
+    public async Task GetDriversFromDirectoryAsync_WithSearchPattern_FiltersCorrectly()
+    {
+        // Arrange
+        var testDir = Path.Combine(Path.GetTempPath(), $"drivers_{Guid.NewGuid()}");
+        Directory.CreateDirectory(testDir);
+
+        try
+        {
+            // Create different types of files
+            var infFile = Path.Combine(testDir, "driver1.inf");
+            var txtFile = Path.Combine(testDir, "readme.txt");
+            File.WriteAllText(infFile, "INF content");
+            File.WriteAllText(txtFile, "Text content");
+
+            // Act
+            var result = await GeneralDrivelution.GetDriversFromDirectoryAsync(testDir, "*.inf");
+
+            // Assert
+            Assert.NotNull(result);
+
+            // Should only find .inf files
+            // The count depends on whether the platform supports parsing .inf files
+        }


This test doesn't assert the filtering behavior it describes: it only checks result is non-null and then exits. As written it will pass even if GetDriversFromDirectoryAsync ignores searchPattern or always returns an empty list. Add assertions that every returned DriverInfo.FilePath matches *.inf and (when running on Windows or when parsing is expected) that exactly one driver is returned for the single .inf file created.

Copilot · 2026-02-09T09:57:56Z

src/c#/DrivelutionTest/GeneralDrivelutionTests.cs

+    /// <summary>
+    /// Tests that GetDriversFromDirectoryAsync handles cancellation.
+    /// </summary>
+    [Fact]
+    public async Task GetDriversFromDirectoryAsync_WithCancellation_HandlesCancellation()
+    {
+        // Arrange
+        var testDir = Path.Combine(Path.GetTempPath(), $"drivers_{Guid.NewGuid()}");
+        Directory.CreateDirectory(testDir);
+
+        try
+        {
+            var cts = new CancellationTokenSource();
+            cts.Cancel();
+
+            // Act
+            var result = await GeneralDrivelution.GetDriversFromDirectoryAsync(testDir, null, cts.Token);
+
+            // Assert - Should complete without throwing or return empty list
+            Assert.NotNull(result);
+        }


This cancellation test only asserts the result is non-null, so it doesn't verify that cancellation is actually honored (e.g., returning an empty/partial list promptly and without doing work). Strengthen it by creating enough files to force iteration and asserting either that the returned list is empty when already-canceled, or that execution stops early (e.g., by checking it returns quickly / fewer results than total).

Copilot · 2026-02-09T09:57:57Z

src/c#/GeneralUpdate.Drivelution/Windows/Implementation/WindowsGeneralDrivelution.cs

+                    // Try to extract publisher from certificate
+                    using var cert2 = new System.Security.Cryptography.X509Certificates.X509Certificate2(filePath);
+                    var subject = cert2.Subject;
+
+                    // Extract CN (Common Name) from subject
+                    var cnIndex = subject.IndexOf("CN=");
+                    if (cnIndex >= 0)
+                    {
+                        var cnStart = cnIndex + 3;
+                        var cnEnd = subject.IndexOf(',', cnStart);
+
+                        string publisher;
+                        if (cnEnd > cnStart)
+                        {
+                            publisher = subject.Substring(cnStart, cnEnd - cnStart);
+                        }
+                        else
+                        {
+                            // No comma after CN, take the rest of the string
+                            publisher = subject.Substring(cnStart);
+                        }
+
+                        if (!string.IsNullOrEmpty(publisher))
+                        {
+                            driverInfo.TrustedPublishers.Add(publisher);
+                        }


The signer certificate extraction is incorrect here: new X509Certificate2(filePath) loads a certificate file (e.g., .cer/.pfx), not the Authenticode signer certificate embedded in a signed driver/INF/PE file. This will usually throw or produce unrelated data, so TrustedPublishers will be wrong/missing. Prefer using X509Certificate.CreateFromSignedFile(filePath) (as already done in WindowsSignatureHelper) and then wrap it in X509Certificate2, and extract the publisher via GetNameInfo/distinguished name parsing rather than manual CN= substring parsing.

Suggested change

// Try to extract publisher from certificate

using var cert2 = new System.Security.Cryptography.X509Certificates.X509Certificate2(filePath);

var subject = cert2.Subject;

// Extract CN (Common Name) from subject

var cnIndex = subject.IndexOf("CN=");

if (cnIndex >= 0)

{

var cnStart = cnIndex + 3;

var cnEnd = subject.IndexOf(',', cnStart);

string publisher;

if (cnEnd > cnStart)

{

publisher = subject.Substring(cnStart, cnEnd - cnStart);

}

else

{

// No comma after CN, take the rest of the string

publisher = subject.Substring(cnStart);

}

if (!string.IsNullOrEmpty(publisher))

{

driverInfo.TrustedPublishers.Add(publisher);

}

// Try to extract publisher from Authenticode signer certificate

using var signerCert = System.Security.Cryptography.X509Certificates.X509Certificate.CreateFromSignedFile(filePath);

using var cert2 = new System.Security.Cryptography.X509Certificates.X509Certificate2(signerCert);

// Use certificate API to get a user-friendly name (publisher/common name)

var publisher = cert2.GetNameInfo(System.Security.Cryptography.X509Certificates.X509NameType.SimpleName, false);

if (!string.IsNullOrEmpty(publisher))

{

driverInfo.TrustedPublishers.Add(publisher);

Copilot · 2026-02-09T09:57:57Z

src/c#/GeneralUpdate.Drivelution/Windows/Implementation/WindowsGeneralDrivelution.cs

+    {
+        try
+        {
+            var fileInfo = new FileInfo(filePath);


fileInfo is created but never used, which adds noise and can trigger analyzer warnings. Remove it or use it for metadata (e.g., file size / last write time) if intended.

Suggested change

var fileInfo = new FileInfo(filePath);

Copilot · 2026-02-09T09:57:57Z

src/c#/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs

+            // Try to get package info using dpkg-deb command
+            // Use proper argument passing to avoid injection issues
+            var escapedPath = debPath.Replace("'", "'\\''");
+            var output = await ExecuteCommandAsync("dpkg-deb", $"-I '{escapedPath}'", cancellationToken);
+            var lines = output.Split('\n');


ExecuteCommandAsync uses ProcessStartInfo with UseShellExecute = false, so shell-style quoting/escaping (wrapping the path in single quotes and replacing ' with '\'') is not interpreted and can cause dpkg-deb to receive literal quotes/backslashes and fail to find the file. Pass arguments without shell quoting, ideally via ProcessStartInfo.ArgumentList (e.g., -I, --, and debPath as separate arguments). Adding -- also prevents option-injection if a filename begins with -.

Copilot · 2026-02-09T09:57:57Z

src/c#/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs

+            // Try to get module info using modinfo command
+            var output = await ExecuteCommandAsync("modinfo", koPath, cancellationToken);
+            var lines = output.Split('\n');


ExecuteCommandAsync("modinfo", koPath, ...) passes the module path as the raw Arguments string. If koPath contains spaces/quotes, modinfo will see it as multiple arguments and fail. Also, if a filename begins with -, it can be interpreted as an option. Prefer ProcessStartInfo.ArgumentList to pass -- and the path as a single argument (or otherwise quote/escape the path correctly for ProcessStartInfo.Arguments).

Copilot · 2026-02-09T09:57:58Z

src/c#/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs

+            // Default to kernel modules for Linux
+            var pattern = searchPattern ?? "*.ko";
+            var driverFiles = Directory.GetFiles(directoryPath, pattern, SearchOption.AllDirectories);
+
+            // Also look for .deb and .rpm packages if no specific pattern was provided
+            if (searchPattern == null)
+            {
+                var debFiles = Directory.GetFiles(directoryPath, "*.deb", SearchOption.AllDirectories);
+                var rpmFiles = Directory.GetFiles(directoryPath, "*.rpm", SearchOption.AllDirectories);
+                driverFiles = driverFiles.Concat(debFiles).Concat(rpmFiles).ToArray();
+            }
+
+            _logger.Information("Found {Count} driver files matching pattern: {Pattern}", driverFiles.Length, pattern);


The log message reports files "matching pattern: {Pattern}" using pattern, but when searchPattern == null the code also adds *.deb and *.rpm files into driverFiles. This makes the log misleading and complicates troubleshooting. Consider logging the full set of included patterns (e.g., *.ko, *.deb, *.rpm) or logging counts per extension.

Copilot · 2026-02-09T09:57:58Z

src/c#/GeneralUpdate.Drivelution/Linux/Implementation/LinuxGeneralDrivelution.cs

+    {
+        try
+        {
+            var fileInfo = new FileInfo(filePath);


fileInfo is created but never used, which adds noise and can trigger analyzer warnings. Remove it or use it for intended metadata extraction.

Suggested change

var fileInfo = new FileInfo(filePath);

* add GeneralUpdate.Drivelution * Add comprehensive documentation for GeneralUpdate.Drivelution (#139) * Initial plan * Add comprehensive README documentation for GeneralUpdate.Drivelution Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> * Add comprehensive test suite for GeneralUpdate.Drivelution (#140) * Initial plan * Add comprehensive test cases for GeneralUpdate.Drivelution Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> * Address code review feedback: improve test quality and cleanup Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> * Rename DriverUpdate to Drivelution across codebase (#141) * Initial plan * Replace all instances of DriverUpdate with Drivelution Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> * Update error code prefixes from DU_ to DR_ Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> * Add GetDriversFromDirectoryAsync for local driver discovery (#142) * Initial plan * Add GetDriversFromDirectoryAsync method to read driver information from local directory Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> * Add tests for GetDriversFromDirectoryAsync method Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> * Fix security issues: prevent command injection and improve certificate parsing Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> * Translate all Chinese annotations to English Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>

Initial plan

80c2344

Copilot AI assigned Copilot and JusterZhu Feb 9, 2026

Copilot AI mentioned this pull request Feb 9, 2026

add GeneralUpdate.Drivelution #138

Merged

Copilot started work on behalf of JusterZhu February 9, 2026 09:23 View session

Copilot AI and others added 3 commits February 9, 2026 09:27

Add GetDriversFromDirectoryAsync method to read driver information fr…

54acd63

…om local directory Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>

Add tests for GetDriversFromDirectoryAsync method

406494e

Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>

Fix security issues: prevent command injection and improve certificat…

07563cd

…e parsing Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add GeneralUpdate.Drivelution code updates~~ Add GetDriversFromDirectoryAsync for local driver discovery Feb 9, 2026

Copilot AI requested a review from JusterZhu February 9, 2026 09:32

Copilot finished work on behalf of JusterZhu February 9, 2026 09:32

Copilot started work on behalf of JusterZhu February 9, 2026 09:41 View session

Translate all Chinese annotations to English

7ddd2f1

Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>

Copilot finished work on behalf of JusterZhu February 9, 2026 09:46

JusterZhu approved these changes Feb 9, 2026

View reviewed changes

JusterZhu marked this pull request as ready for review February 9, 2026 09:51

Copilot AI review requested due to automatic review settings February 9, 2026 09:51

JusterZhu merged commit f443f1f into driver Feb 9, 2026
2 checks passed

JusterZhu deleted the copilot/sub-pr-138 branch February 9, 2026 09:51

Copilot started reviewing on behalf of JusterZhu February 9, 2026 09:53 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GetDriversFromDirectoryAsync for local driver discovery#142

Add GetDriversFromDirectoryAsync for local driver discovery#142
JusterZhu merged 5 commits intodriverfrom
copilot/sub-pr-138

Copilot AI commented Feb 9, 2026 •

edited

Loading

Uh oh!

JusterZhu commented Feb 9, 2026

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JusterZhu commented Feb 9, 2026

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 9, 2026 •

edited

Loading