Instead of p-value, grelu is returning fimo_p-value #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

avantikalal merged 1 commit into main from fimo_pval

Oct 27, 2025

Collaborator

MuhammedHasan commented Oct 27, 2025 •

edited

Loading

And this seems to be because the current grelu code renames the column
https://github.com/Genentech/gReLU/blob/93d95203cb69762a53f4bece147133c1e2ede5cb/src/grelu/interpret/motifs.py#L206


          attrs

12a4120

MuhammedHasan changed the title ~~attrs~~ Instead of p-value, grelu is returning fimo_p-value

MuhammedHasan requested a review from avantikalal

October 27, 2025 16:08

avantikalal merged commit feae779 into main

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet