bug fix training and gene mask lightning model #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuhammedHasan
added
enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR implements a bug fix for training and introduces a new GenenMaskLightningModel class that extends the base LightningModel with gene masking functionality.
- Adds a new
GenenMaskLightningModelclass that applies gene masks during forward passes - Includes test coverage for the new model class
- Updates import statements to support the new functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/decima/model/lightning.py | Implements new GenenMaskLightningModel class with gene masking capability |
| tests/test_lightning.py | Adds test for the new gene mask model's forward method |
| src/decima/data/dataset.py | Updates imports to include additional functions from grelu |
src/decima/model/lightning.py
Outdated
| return self(batch) | ||
|
|
||
|
|
||
| class GenenMaskLightningModel(LightningModel): |
There was a problem hiding this comment.
The class name 'GenenMaskLightningModel' contains a typo. It should be 'GeneMaskLightningModel' (missing 'e' in 'Gene').
avantikalal
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.