Fix intermittent failures in AccountServiceTests #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihle
reviewed
May 20, 2025
| try { | ||
| restResponse = accountService.getAccounts(request); | ||
| break; // Success, exit the retry loop | ||
| } catch (GenabilityException e) { |
There was a problem hiding this comment.
I am assuming the not found case / 404 is a Genability Exception.
There was a problem hiding this comment.
the not found case is a 500
GenabilityException: Failed GET http://family-main-preview/rest/v1/accounts?fields=ext&pageCount=5&search=JAVA+CLIENT+TEST+ACCOUNT&searchOn=accountName: HTTP error code : 500
mihle
reviewed
May 20, 2025
| throw e; // Re-throw if we've exhausted retries | ||
| } | ||
|
|
||
| System.out.println("Search request failed, retrying (" + retryCount + "/" + maxRetries + ")"); |
There was a problem hiding this comment.
I would remove this logging line. If we need to log, we should use a framework provided logging.
mihle
approved these changes
May 20, 2025
mihle
approved these changes
May 20, 2025
mihle
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The testPaginatedAccountList test in AccountServiceTests was experiencing intermittent 500 errors when searching for newly created accounts:
GenabilityException: Failed GET http://family-main-preview/rest/v1/accounts?fields=ext&pageCount=5&search=JAVA+CLIENT+TEST+ACCOUNT&searchOn=accountName: HTTP error code : 500The issue occurred because:
Previous PR: #76 (tackling each tests separately now)