Skip to content

fix: remove Okta Verify from push notification pattern#23

Merged
GeiserX merged 1 commit into
mainfrom
fix/okta-verify-pattern
May 13, 2026
Merged

fix: remove Okta Verify from push notification pattern#23
GeiserX merged 1 commit into
mainfrom
fix/okta-verify-pattern

Conversation

@GeiserX
Copy link
Copy Markdown
Owner

@GeiserX GeiserX commented May 13, 2026

Summary

  • Remove Okta Verify from the push notification regex in the README expect template
  • The broad pattern matches before the number-matching pattern when tools output "Open Okta Verify" prior to showing the MFA number, causing the wrong notification to display

Test plan

  • Verified locally: auto-login.exp now correctly shows the number notification instead of the generic push message

Summary by CodeRabbit

  • Documentation
    • Updated the auto-login script template to refine multi-factor authentication (MFA) prompt detection, improving compatibility with various approval notification styles.

Review Change Stack

The broad "Okta Verify" match fires before the number-matching pattern
when the login tool outputs "Open Okta Verify" prior to showing the
actual MFA number. This causes the generic push notification to display
instead of the specific number the user needs to enter.
@GeiserX GeiserX merged commit ed1f8d6 into main May 13, 2026
10 of 11 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c8d93a43-ccd1-47e6-a550-a84eaeb5c230

📥 Commits

Reviewing files that changed from the base of the PR and between 5ddfc3f and d1ee5af.

📒 Files selected for processing (1)
  • README.md

📝 Walkthrough

Walkthrough

The README's auto-login expect script template is updated to narrow the MFA prompt detection regex pattern. The "Okta Verify" alternative is removed, while patterns for "push notification," "Waiting.*approval," "verify.*identity," and "Please Approve" are retained.

Changes

MFA Prompt Detection Update

Layer / File(s) Summary
MFA prompt regex pattern refinement
README.md
The expect pattern matching push/approval-style MFA prompts is updated to remove Okta Verify detection while keeping alternatives for push notifications, approval waiting, identity verification, and manual approval.

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/okta-verify-pattern

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@GeiserX GeiserX deleted the fix/okta-verify-pattern branch May 13, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant