fix: harden cross-platform compatibility, security, and test coverage#21
Merged
Conversation
- Security: restrict config dir to 700, config file to 600 on Unix - Security: validate profile name format (prevent CLI flag injection) - Security: add TTY warning guard to aws-cred-export.mjs - Bug: reactive path no longer falls back to loginCmd (may hang without TTY) - Bug: add timeout message when wait loop expires in aws-auth-refresh - Cross-platform: add shell option for Windows aws CLI resolution - Cross-platform: case-insensitive path comparison for isPlugin on Windows - Cross-platform: sleepSync fallback when SharedArrayBuffer unavailable - Feature: support ISO-8601 expiration timestamps (some providers use these) - CI: add version consistency check (package.json vs marketplace.json) - CI: fix duplicate test execution on coverage matrix cell - CI: harden release workflow with duplicate release guard and HEAD^1 - Fix marketplace.json version drift (0.3.0 → 0.3.2) - Tests: add future-timestamp lock, garbage lock, concurrent lock, ISO-8601, profile mismatch cases (48 tests total, all passing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive fixes from 8 specialized code reviewers analyzing PRs #9–#16:
loginCmd(could hang without TTY)aws.exeresolution, case-insensitive plugin path detection,sleepSyncfallbackTest plan
node --test lib.test.mjs)node --check *.mjs)