Skip to content

fix: treat future-timestamp lock files as stale + rename CLAUDE.md#20

Merged
GeiserX merged 2 commits into
mainfrom
ci/auto-release
May 7, 2026
Merged

fix: treat future-timestamp lock files as stale + rename CLAUDE.md#20
GeiserX merged 2 commits into
mainfrom
ci/auto-release

Conversation

@GeiserX
Copy link
Copy Markdown
Owner

@GeiserX GeiserX commented May 7, 2026

Summary

  • Lock fix: A lock file with a future timestamp (clock skew or corruption) would create a permanent deadlock — auto-login could never fire again. Now treats negative age as stale, same as NaN/garbage content.
  • Rename: AGENTS.md → CLAUDE.md (follows upstream convention change)
  • CodeRabbit config: minor path update

Context

The major changes from this session were:

Test plan

  • node --test lib.test.mjs — 46 tests passing including lock file edge cases
  • Verified lock file with future timestamp is now treated as stale
  • No breaking changes to public API

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates project documentation by replacing AGENTS.md with CLAUDE.md, which documents the cc-aws-keepalive Claude Code plugin architecture, configuration, integration requirements, and test procedures. The CodeRabbit knowledge base configuration is updated to reference the new documentation file.

Changes

Plugin Documentation and Configuration

Layer / File(s) Summary
Plugin Documentation
CLAUDE.md
CLAUDE.md created with plugin documentation covering architecture (config/credential parsing, credential export, cross-terminal refresh, expiration warnings, ANSI statusline, cross-platform installer), configuration schema and locations, manual Claude settings integration requirements, platform-specific implementation notes, and Node.js test script usage.
Knowledge Base Configuration
.coderabbit.yaml
Knowledge base filePatterns entry updated from "AGENTS.md" to "CLAUDE.md".

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims to both fix stale lock file handling and rename a file, but the changeset only shows a file rename (AGENTS.md→CLAUDE.md) and config update with no lock file changes present. Update the title to reflect only the actual changes: 'refactor: rename AGENTS.md to CLAUDE.md' or clarify what lock file changes are included.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/auto-release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.coderabbit.yaml (1)

49-52: ⚡ Quick win

Remove duplicate filePatterns entry.

"CLAUDE.md" appears twice, which is redundant and easy to clean up.

Suggested diff
   code_guidelines:
     enabled: true
     filePatterns:
       - "CLAUDE.md"
-      - "CLAUDE.md"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.coderabbit.yaml around lines 49 - 52, The filePatterns array in
.coderabbit.yaml contains a duplicated entry ("CLAUDE.md")—remove the duplicate
so each pattern appears only once; update the filePatterns list (the
"filePatterns" key) to include unique entries only, e.g., keep a single
"CLAUDE.md" and delete the redundant line.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.coderabbit.yaml:
- Around line 49-52: The filePatterns array in .coderabbit.yaml contains a
duplicated entry ("CLAUDE.md")—remove the duplicate so each pattern appears only
once; update the filePatterns list (the "filePatterns" key) to include unique
entries only, e.g., keep a single "CLAUDE.md" and delete the redundant line.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e81d9478-f20e-46db-b6f1-a24082164aaf

📥 Commits

Reviewing files that changed from the base of the PR and between 607db53 and 875636a.

📒 Files selected for processing (2)
  • .coderabbit.yaml
  • CLAUDE.md

A lock file with a timestamp in the future (clock skew or corruption)
would create a permanent lock that could never be acquired. Now treats
negative age as stale, same as NaN/garbage content.
@GeiserX GeiserX changed the title Rename AGENTS.md to CLAUDE.md fix: treat future-timestamp lock files as stale + rename CLAUDE.md May 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.53%. Comparing base (607db53) to head (2f33f70).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files           2        2           
  Lines         162      162           
  Branches       37       37           
=======================================
  Hits          158      158           
  Misses          4        4           
Files with missing lines Coverage Δ
lib.mjs 97.14% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GeiserX GeiserX merged commit 93648c5 into main May 7, 2026
13 checks passed
@GeiserX GeiserX deleted the ci/auto-release branch May 7, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant