fix: treat future-timestamp lock files as stale + rename CLAUDE.md#20
Conversation
📝 WalkthroughWalkthroughThis PR updates project documentation by replacing AGENTS.md with CLAUDE.md, which documents the cc-aws-keepalive Claude Code plugin architecture, configuration, integration requirements, and test procedures. The CodeRabbit knowledge base configuration is updated to reference the new documentation file. ChangesPlugin Documentation and Configuration
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.coderabbit.yaml (1)
49-52: ⚡ Quick winRemove duplicate
filePatternsentry.
"CLAUDE.md"appears twice, which is redundant and easy to clean up.Suggested diff
code_guidelines: enabled: true filePatterns: - "CLAUDE.md" - - "CLAUDE.md"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.coderabbit.yaml around lines 49 - 52, The filePatterns array in .coderabbit.yaml contains a duplicated entry ("CLAUDE.md")—remove the duplicate so each pattern appears only once; update the filePatterns list (the "filePatterns" key) to include unique entries only, e.g., keep a single "CLAUDE.md" and delete the redundant line.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.coderabbit.yaml:
- Around line 49-52: The filePatterns array in .coderabbit.yaml contains a
duplicated entry ("CLAUDE.md")—remove the duplicate so each pattern appears only
once; update the filePatterns list (the "filePatterns" key) to include unique
entries only, e.g., keep a single "CLAUDE.md" and delete the redundant line.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e81d9478-f20e-46db-b6f1-a24082164aaf
📒 Files selected for processing (2)
.coderabbit.yamlCLAUDE.md
A lock file with a timestamp in the future (clock skew or corruption) would create a permanent lock that could never be acquired. Now treats negative age as stale, same as NaN/garbage content.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 2 2
Lines 162 162
Branches 37 37
=======================================
Hits 158 158
Misses 4 4
🚀 New features to boost your workflow:
|
Summary
Context
The major changes from this session were:
terminal-notifier -ignoreDnDwith custom AWS icon) — lives in local~/.config/cc-aws-keepalive/auto-login.exp, not tracked in repoTest plan
node --test lib.test.mjs— 46 tests passing including lock file edge cases